Chromium Code Reviews
Description[kernel] Don't output a -1 token position, it will crash observatory.
Before this, for instance clicking on "dart:async" under "libraries"
would give a stacktrace and not show the source of "dart:async".
The cause was a "no position" (-1) mapping to column 0
(in what is supposed to be a 1-indexed world), thus becomming -1 in a
0-indexed world, being passed as the start index to indexOf yielding
an out-of-range exception.
BUG=
R=kustermann@google.com
Committed: https://github.com/dart-lang/sdk/commit/cac814a203cb1935bf1990fe5fd556344c2d85c4
Patch Set 1 #
Messages
Total messages: 5 (2 generated)
|
|||||||||||||||||||