Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 3005113002: [kernel] Don't output a -1 token position, it will crash observatory. (Closed)

Created:
3 years, 3 months ago by jensj
Modified:
3 years, 3 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[kernel] Don't output a -1 token position, it will crash observatory. Before this, for instance clicking on "dart:async" under "libraries" would give a stacktrace and not show the source of "dart:async". The cause was a "no position" (-1) mapping to column 0 (in what is supposed to be a 1-indexed world), thus becomming -1 in a 0-indexed world, being passed as the start index to indexOf yielding an out-of-range exception. BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/cac814a203cb1935bf1990fe5fd556344c2d85c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/kernel_binary_flowgraph.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
3 years, 3 months ago (2017-09-04 11:23:36 UTC) #2
kustermann
lgtm
3 years, 3 months ago (2017-09-04 11:28:40 UTC) #3
jensj
3 years, 3 months ago (2017-09-04 11:29:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cac814a203cb1935bf1990fe5fd556344c2d85c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698