Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: runtime/vm/kernel_binary_flowgraph.cc

Issue 3005113002: [kernel] Don't output a -1 token position, it will crash observatory. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/kernel_binary_flowgraph.h" 5 #include "vm/kernel_binary_flowgraph.h"
6 #include "vm/compiler.h" 6 #include "vm/compiler.h"
7 #include "vm/longjump.h" 7 #include "vm/longjump.h"
8 #include "vm/object_store.h" 8 #include "vm/object_store.h"
9 9
10 #if !defined(DART_PRECOMPILED_RUNTIME) 10 #if !defined(DART_PRECOMPILED_RUNTIME)
(...skipping 4622 matching lines...) Expand 10 before | Expand all | Expand 10 after
4633 TokenPosition StreamingFlowGraphBuilder::ReadPosition(bool record) { 4633 TokenPosition StreamingFlowGraphBuilder::ReadPosition(bool record) {
4634 TokenPosition position = reader_->ReadPosition(); 4634 TokenPosition position = reader_->ReadPosition();
4635 if (record) { 4635 if (record) {
4636 record_token_position(position); 4636 record_token_position(position);
4637 } 4637 }
4638 return position; 4638 return position;
4639 } 4639 }
4640 4640
4641 void StreamingFlowGraphBuilder::record_token_position(TokenPosition position) { 4641 void StreamingFlowGraphBuilder::record_token_position(TokenPosition position) {
4642 if (record_for_script_id_ == current_script_id_ && 4642 if (record_for_script_id_ == current_script_id_ &&
4643 record_token_positions_into_ != NULL) { 4643 record_token_positions_into_ != NULL && position.IsReal()) {
4644 record_token_positions_into_->Add(position.value()); 4644 record_token_positions_into_->Add(position.value());
4645 } 4645 }
4646 } 4646 }
4647 4647
4648 void StreamingFlowGraphBuilder::record_yield_position(TokenPosition position) { 4648 void StreamingFlowGraphBuilder::record_yield_position(TokenPosition position) {
4649 if (record_for_script_id_ == current_script_id_ && 4649 if (record_for_script_id_ == current_script_id_ &&
4650 record_yield_positions_into_ != NULL) { 4650 record_yield_positions_into_ != NULL && position.IsReal()) {
4651 record_yield_positions_into_->Add(position.value()); 4651 record_yield_positions_into_->Add(position.value());
4652 } 4652 }
4653 } 4653 }
4654 4654
4655 Tag StreamingFlowGraphBuilder::ReadTag(uint8_t* payload) { 4655 Tag StreamingFlowGraphBuilder::ReadTag(uint8_t* payload) {
4656 return reader_->ReadTag(payload); 4656 return reader_->ReadTag(payload);
4657 } 4657 }
4658 4658
4659 Tag StreamingFlowGraphBuilder::PeekTag(uint8_t* payload) { 4659 Tag StreamingFlowGraphBuilder::PeekTag(uint8_t* payload) {
4660 return reader_->PeekTag(payload); 4660 return reader_->PeekTag(payload);
(...skipping 3095 matching lines...) Expand 10 before | Expand all | Expand 10 after
7756 } 7756 }
7757 } 7757 }
7758 7758
7759 return Array::Handle(Array::null()); 7759 return Array::Handle(Array::null());
7760 } 7760 }
7761 7761
7762 } // namespace kernel 7762 } // namespace kernel
7763 } // namespace dart 7763 } // namespace dart
7764 7764
7765 #endif // !defined(DART_PRECOMPILED_RUNTIME) 7765 #endif // !defined(DART_PRECOMPILED_RUNTIME)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698