Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 3004913002: Stop building export scopes in KernelDriver. (Closed)

Created:
3 years, 3 months ago by scheglov
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop building export scopes in KernelDriver. Fasta already store exports scopes into Kernel. It was added some time ago and improved recently. https://github.com/dart-lang/sdk/commit/234c4a7f493e1fc3dafc393472e39163ac2ad783 R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/288b203b6cf500ee84e6ee5873b8192b4863f272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -124 lines) Patch
M pkg/front_end/lib/src/incremental/file_state.dart View 5 chunks +0 lines, -30 lines 0 comments Download
M pkg/front_end/lib/src/incremental/kernel_driver.dart View 3 chunks +1 line, -36 lines 0 comments Download
M pkg/front_end/test/src/incremental/file_state_test.dart View 2 chunks +2 lines, -58 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 3 months ago (2017-08-30 17:23:15 UTC) #1
Siggi Cherem (dart-lang)
lgtm
3 years, 3 months ago (2017-08-30 17:33:49 UTC) #2
scheglov
3 years, 3 months ago (2017-08-30 17:38:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
288b203b6cf500ee84e6ee5873b8192b4863f272 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698