Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: pkg/front_end/lib/src/incremental/file_state.dart

Issue 3004913002: Stop building export scopes in KernelDriver. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/incremental/kernel_driver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/incremental/file_state.dart
diff --git a/pkg/front_end/lib/src/incremental/file_state.dart b/pkg/front_end/lib/src/incremental/file_state.dart
index e02c7b5139b5d339e1deb3443d5a901112426825..6c7118019e33a5203afdfaefc7d652ca8263ca83 100644
--- a/pkg/front_end/lib/src/incremental/file_state.dart
+++ b/pkg/front_end/lib/src/incremental/file_state.dart
@@ -46,7 +46,6 @@ class FileState {
bool _hasMixinApplication;
List<int> _apiSignature;
- List<NamespaceExport> _exports;
List<FileState> _importedLibraries;
List<FileState> _exportedLibraries;
List<FileState> _partFiles;
@@ -81,9 +80,6 @@ class FileState {
/// The list of the libraries exported by this library.
List<FileState> get exportedLibraries => _exportedLibraries;
- /// The list of the exported files with combinators.
- List<NamespaceExport> get exports => _exports;
-
@override
int get hashCode => uri.hashCode;
@@ -168,7 +164,6 @@ class FileState {
_importedLibraries = <FileState>[];
_exportedLibraries = <FileState>[];
_partFiles = <FileState>[];
- _exports = <NamespaceExport>[];
{
FileState coreFile = await _getFileForRelativeUri('dart:core');
// TODO(scheglov) add error handling
@@ -187,7 +182,6 @@ class FileState {
FileState file = await _getFileForRelativeUri(export_.uri);
if (file != null) {
_exportedLibraries.add(file);
- _exports.add(new NamespaceExport(file, export_.combinators));
}
}
for (var part_ in unlinkedUnit.parts) {
@@ -398,30 +392,6 @@ class LibraryCycle {
}
}
-/// Information about a single `export` directive.
-class NamespaceExport {
- final FileState library;
- final List<UnlinkedCombinator> combinators;
-
- NamespaceExport(this.library, this.combinators);
-
- /// Return `true` if the [name] satisfies the sequence of the [combinators].
- bool isExposed(String name) {
- for (var combinator in combinators) {
- if (combinator.isShow) {
- if (!combinator.names.contains(name)) {
- return false;
- }
- } else {
- if (combinator.names.contains(name)) {
- return false;
- }
- }
- }
- return true;
- }
-}
-
/// [FileSystemState] based implementation of [FileSystem].
/// It provides a consistent view on the known file system state.
class _FileSystemView implements FileSystem {
« no previous file with comments | « no previous file | pkg/front_end/lib/src/incremental/kernel_driver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698