Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Unified Diff: pkg/front_end/testcases/shaker.status

Issue 3004703002: Don't export unnamed mixins. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/testcases/shaker.status
diff --git a/pkg/front_end/testcases/shaker.status b/pkg/front_end/testcases/shaker.status
index f02e7234845ac2b78744192c7b526a07d0ae3346..90073e4002910970fc55103cb9cc511fdb046505 100644
--- a/pkg/front_end/testcases/shaker.status
+++ b/pkg/front_end/testcases/shaker.status
@@ -6,3 +6,4 @@
# tree-shaking piece of the modular compilation in fasta.
include_field_type: Fail # Fasta does not create interfaceTarget on accessors.
+transitive_mixins: Fail # Don't know how to update expectations.
Siggi Cherem (dart-lang) 2017/08/28 15:57:54 not sure I understand the reason in this comment
ahe 2017/08/28 18:19:24 The expectation file (pkg/front_end/testcases/shak
Siggi Cherem (dart-lang) 2017/08/28 19:43:29 Thank you, we can make the .shaker file self docum
ahe 2017/08/29 09:15:24 So in other words, I'm actually supposed to edit p
Siggi Cherem (dart-lang) 2017/08/29 15:43:10 correct - would it help if we change the extension
ahe 2017/08/29 16:24:57 That would help. And also if the file didn't say "

Powered by Google App Engine
This is Rietveld 408576698