Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: pkg/front_end/testcases/shaker.status

Issue 3004703002: Don't export unnamed mixins. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 # Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 # for details. All rights reserved. Use of this source code is governed by a 2 # for details. All rights reserved. Use of this source code is governed by a
3 # BSD-style license that can be found in the LICENSE.md file. 3 # BSD-style license that can be found in the LICENSE.md file.
4 4
5 # Status file for the shaker_test.dart test suite. This is only testing the 5 # Status file for the shaker_test.dart test suite. This is only testing the
6 # tree-shaking piece of the modular compilation in fasta. 6 # tree-shaking piece of the modular compilation in fasta.
7 7
8 include_field_type: Fail # Fasta does not create interfaceTarget on accessors. 8 include_field_type: Fail # Fasta does not create interfaceTarget on accessors.
9 transitive_mixins: Fail # Don't know how to update expectations.
Siggi Cherem (dart-lang) 2017/08/28 15:57:54 not sure I understand the reason in this comment
ahe 2017/08/28 18:19:24 The expectation file (pkg/front_end/testcases/shak
Siggi Cherem (dart-lang) 2017/08/28 19:43:29 Thank you, we can make the .shaker file self docum
ahe 2017/08/29 09:15:24 So in other words, I'm actually supposed to edit p
Siggi Cherem (dart-lang) 2017/08/29 15:43:10 correct - would it help if we change the extension
ahe 2017/08/29 16:24:57 That would help. And also if the file didn't say "
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698