[catapult] Roll forward Chrome reference builds

[catapult] Roll forward Chrome reference builds

Additionally, this CL:
1. Disable InspectorPageTest.testCaptureScreenshot on windows because 
it fails with the new versions of Chrome.
2. Do not use zipfile.ZipFile for unzipping Chrome builds, because
it doesn't work with symbolic links which were introduced in M59 MacOS 
builds. See crbug.com/700097.

BUG=chromium:753948
Review-Url: https://codereview.chromium.org/3004533002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/92387bc7d0acf29859000ead5254b1c8beff0ade

[xunjieli, 2017-08-23 14:08:24]

xunjieli@chromium.org changed reviewers:
+ sullivan@chromium.org

[xunjieli, 2017-08-23 14:08:28]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 14:08:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-23 14:12:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-23 14:12:29]

Dry run: Try jobs failed on following builders:
  Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)

[xunjieli, 2017-08-23 14:16:18]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 14:16:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-08-23 14:19:55]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 14:19:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sullivan, 2017-08-23 14:24:05]

lgtm

[xunjieli, 2017-08-23 14:34:38]

The CQ bit was unchecked by xunjieli@chromium.org

[xunjieli, 2017-08-23 14:34:40]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2017-08-23 14:34:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-23 15:26:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-23 15:26:10]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[xunjieli, 2017-08-23 16:21:01]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 16:21:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-08-23 16:37:44]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 16:37:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-23 16:55:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-23 16:55:41]

Dry run: Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[xunjieli, 2017-08-23 17:03:32]

Patchset #5 (id:80001) has been deleted

[xunjieli, 2017-08-23 17:13:56]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 17:14:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-08-23 17:18:46]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 17:18:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-08-23 17:19:00]

Patchset #5 (id:100001) has been deleted

[xunjieli, 2017-08-23 17:19:07]

Patchset #4 (id:60001) has been deleted

[xunjieli, 2017-08-23 18:01:59]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 18:02:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-08-23 19:46:28]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 19:46:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-08-23 19:48:55]

Description was changed from

==========
[catapult] Roll forward Chrome reference builds

BUG=chromium:753948
==========

to

==========
[catapult] Roll forward Chrome reference builds

Additionally, this CL:
1. Disable InspectorPageTest.testCaptureScreenshot on windows because 
it fails with the new versions of Chrome.
2. Do not use zipfile.ZipFile for unzipping Chrome builds, because
it doesn't work with symbolic links which were introduced in M59 MacOS 
builds. See crbug.com/700097.

BUG=chromium:753948
==========

[xunjieli, 2017-08-23 19:49:03]

Patchset #5 (id:140001) has been deleted

[xunjieli, 2017-08-23 19:54:27]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 19:54:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-08-23 19:54:56]

Patchset #6 (id:180001) has been deleted

[xunjieli, 2017-08-23 19:55:59]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 19:56:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-23 20:24:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-23 20:25:00]

Dry run: Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[xunjieli, 2017-08-23 20:47:32]

Patchset #6 (id:200001) has been deleted

[xunjieli, 2017-08-23 20:47:45]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 20:47:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-08-23 21:05:38]

Hi Annie, could you take a look at diff between PS#3 and PS#6 ? In M59, Chrome
MacOS builds introduced symbolic links which are handled incorrectly by zipfile
(crbug.com/700097). I changed dependency manager util to not use zipfile on
MacOS. I also disabled one test in inspector_page_unittest.py because it doesn't
work for the new versions of Chrome.

Thanks!

[commit-bot: I haz the power, 2017-08-23 21:14:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-23 21:14:21]

Dry run: This issue passed the CQ dry run.

[sullivan, 2017-08-23 22:22:59]

lgtm

https://codereview.chromium.org/3004533002/diff/220001/telemetry/telemetry/in...
File
telemetry/telemetry/internal/backends/chrome_inspector/inspector_page_unittest.py
(right):

https://codereview.chromium.org/3004533002/diff/220001/telemetry/telemetry/in...
telemetry/telemetry/internal/backends/chrome_inspector/inspector_page_unittest.py:39:
@decorators.Disabled('chromeos', 'mac', 'win')
Should there be a new bug for Windows?

[xunjieli, 2017-08-23 23:11:17]

Thanks for the review!

https://codereview.chromium.org/3004533002/diff/220001/telemetry/telemetry/in...
File
telemetry/telemetry/internal/backends/chrome_inspector/inspector_page_unittest.py
(right):

https://codereview.chromium.org/3004533002/diff/220001/telemetry/telemetry/in...
telemetry/telemetry/internal/backends/chrome_inspector/inspector_page_unittest.py:39:
@decorators.Disabled('chromeos', 'mac', 'win')
On 2017/08/23 22:22:59, sullivan wrote:
> Should there be a new bug for Windows?

Done.

[xunjieli, 2017-08-23 23:11:24]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2017-08-23 23:11:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org
Link to the patchset: https://codereview.chromium.org/3004533002/#ps240001
(title: "filed a bug on the disabled win test")

[commit-bot: I haz the power, 2017-08-23 23:11:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-23 23:38:02]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1503529884168130,
"parent_rev": "b9777c776dee43db2063ad97c9eb7a8a09afd0f3", "commit_rev":
"92387bc7d0acf29859000ead5254b1c8beff0ade"}

[commit-bot: I haz the power, 2017-08-23 23:38:07]

Description was changed from

==========
[catapult] Roll forward Chrome reference builds

Additionally, this CL:
1. Disable InspectorPageTest.testCaptureScreenshot on windows because 
it fails with the new versions of Chrome.
2. Do not use zipfile.ZipFile for unzipping Chrome builds, because
it doesn't work with symbolic links which were introduced in M59 MacOS 
builds. See crbug.com/700097.

BUG=chromium:753948
==========

to

==========
[catapult] Roll forward Chrome reference builds

Additionally, this CL:
1. Disable InspectorPageTest.testCaptureScreenshot on windows because 
it fails with the new versions of Chrome.
2. Do not use zipfile.ZipFile for unzipping Chrome builds, because
it doesn't work with symbolic links which were introduced in M59 MacOS 
builds. See crbug.com/700097.

BUG=chromium:753948

Review-Url: https://codereview.chromium.org/3004533002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-08-23 23:38:08]

Committed patchset #7 (id:240001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...