Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1929)

Issue 3004523004: wpr_go: support armv7l and aarch64 (Closed)

Created:
3 years, 4 months ago by laszio
Modified:
3 years, 4 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : wpr_go: support armv7l and aarch64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M telemetry/bin/update_wpr_go_binary View 2 chunks +8 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/binary_dependencies.json View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Ting-Yuan (Leo) Huang
3 years, 4 months ago (2017-08-24 01:27:58 UTC) #2
achuithb
Have you verified that this works on cros?
3 years, 4 months ago (2017-08-24 01:30:46 UTC) #3
Ting-Yuan (Leo) Huang
On 2017/08/24 01:30:46, achuithb wrote: > Have you verified that this works on cros? Yes. ...
3 years, 4 months ago (2017-08-24 01:31:24 UTC) #4
achuithb
lgtm! Thanks
3 years, 4 months ago (2017-08-24 01:31:41 UTC) #5
xunjieli
double checking .. Have you confirmed that the binaries actually work on those platforms?
3 years, 4 months ago (2017-08-24 01:32:08 UTC) #6
xunjieli
LGTM. Didn't see earlier reply.
3 years, 4 months ago (2017-08-24 01:32:51 UTC) #7
llozano
On 2017/08/24 01:32:51, xunjieli wrote: > LGTM. Didn't see earlier reply. Thanks Ting-Yuan!
3 years, 4 months ago (2017-08-24 06:46:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3004523004/20001
3 years, 4 months ago (2017-08-24 18:19:04 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-24 18:45:16 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698