Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 3004073002: Remove corelib/corelib_strong and migrate last two remaining tests. (Closed)

Created:
3 years, 3 months ago by jcollins
Modified:
3 years, 3 months ago
Reviewers:
*Bob Nystrom, *Bill Hesse
CC:
reviews_dartlang.org, dart2now-team_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove corelib and corelib_strong and migrate last two remaining tests. This includes a migration of linked_hash_map_from_iterable_test and stacktrace_current_test, which were migrated without changes. BUG= R=rnystrom@google.com, whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/51cc9689b342da4e9a781ade96a6d6db8eafff3c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6430 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/tool/status_files/update_all.sh View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 chunk +2 lines, -91 lines 0 comments Download
M pkg/dev_compiler/test/codegen_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/run.js View 1 chunk +2 lines, -2 lines 0 comments Download
D tests/corelib/corelib.status View 1 chunk +0 lines, -316 lines 0 comments Download
D tests/corelib/double_ceil2_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/corelib/errors_test.dart View 1 chunk +0 lines, -77 lines 0 comments Download
D tests/corelib/format_exception_test.dart View 1 chunk +0 lines, -108 lines 0 comments Download
D tests/corelib/growable_list_test.dart View 1 chunk +0 lines, -187 lines 0 comments Download
D tests/corelib/hash_map2_test.dart View 1 chunk +0 lines, -308 lines 0 comments Download
D tests/corelib/linked_hash_map_from_iterable_test.dart View 1 chunk +0 lines, -117 lines 0 comments Download
D tests/corelib/regexp/v8_regexp_utils.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D tests/corelib/set_test.dart View 1 chunk +0 lines, -550 lines 0 comments Download
D tests/corelib/sort_helper.dart View 1 chunk +0 lines, -152 lines 0 comments Download
D tests/corelib/stacktrace_current_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/corelib/symbol_map_helper.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 chunk +1 line, -1 line 1 comment Download
A + tests/corelib_2/linked_hash_map_from_iterable_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/corelib_2/stacktrace_current_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/corelib_strong/corelib_strong.status View 1 chunk +0 lines, -30 lines 0 comments Download
D tests/corelib_strong/corelib_strong_kernel.status View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/corelib_strong/double_ceil2_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/corelib_strong/errors_test.dart View 1 chunk +0 lines, -77 lines 0 comments Download
D tests/corelib_strong/hash_set_test.dart View 1 chunk +0 lines, -363 lines 0 comments Download
D tests/corelib_strong/linked_hash_map_from_iterable_test.dart View 1 chunk +0 lines, -117 lines 0 comments Download
D tests/corelib_strong/regexp/v8_regexp_utils.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D tests/corelib_strong/sort_helper.dart View 1 chunk +0 lines, -155 lines 0 comments Download
D tests/corelib_strong/stacktrace_current_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/corelib_strong/symbol_map_helper.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/zzz View 1 chunk +0 lines, -3487 lines 0 comments Download
M tools/bots/ddc_tests.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gardening/test/parse_build_results_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/migration/lib/src/io.dart View 1 chunk +10 lines, -7 lines 0 comments Download
M tools/status_clean.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/options.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jcollins
This includes a number of cleanups across the SDK repo and deleting these directories could ...
3 years, 3 months ago (2017-08-30 17:29:37 UTC) #3
Bob Nystrom
LGTM!
3 years, 3 months ago (2017-08-30 21:58:51 UTC) #5
Bill Hesse
Changes to test scripts LGTM
3 years, 3 months ago (2017-09-01 14:14:13 UTC) #6
Bill Hesse
https://codereview.chromium.org/3004073002/diff/1/tests/corelib_2/corelib_2.status File tests/corelib_2/corelib_2.status (left): https://codereview.chromium.org/3004073002/diff/1/tests/corelib_2/corelib_2.status#oldcode580 tests/corelib_2/corelib_2.status:580: linked_hash_map_from_iterables_test: Crash Please don't put comments into status files ...
3 years, 3 months ago (2017-09-01 14:15:18 UTC) #7
jcollins
On 2017/09/01 14:15:18, Bill Hesse wrote: > https://codereview.chromium.org/3004073002/diff/1/tests/corelib_2/corelib_2.status > File tests/corelib_2/corelib_2.status (left): > > https://codereview.chromium.org/3004073002/diff/1/tests/corelib_2/corelib_2.status#oldcode580 ...
3 years, 3 months ago (2017-09-01 14:57:14 UTC) #8
jcollins
3 years, 3 months ago (2017-09-01 15:11:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
51cc9689b342da4e9a781ade96a6d6db8eafff3c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698