Issue 3003263002: add support for native methods in class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3003263002: add support for native methods in class

Created:
3 years, 4 months ago by danrubel

Modified:
3 years, 3 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

add support for native methods in class

Patch Set 1 #

Patch Set 2 : update listeners #

Total comments: 1

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -19 lines)			Patch
M	pkg/analyzer/lib/src/fasta/ast_builder.dart	View	1	3 chunks	+21 lines, -3 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_fasta_listener.dart	View		3 chunks	+10 lines, -3 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_fasta_test.dart	View		1 chunk	+37 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_test.dart	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	pkg/analyzer/tool/summary/mini_ast.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/parser/element_listener.dart	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/parser/member_listener.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/parser/node_listener.dart	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	pkg/front_end/lib/src/fasta/parser/listener.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/front_end/lib/src/fasta/parser/parser.dart	View	1	2 chunks	+13 lines, -2 lines	1 comment	Download
M	pkg/front_end/lib/src/fasta/source/diet_listener.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/front_end/lib/src/fasta/source/outline_builder.dart	View	1	4 chunks	+7 lines, -2 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/source/stack_listener.dart	View	1	3 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ahe

3 years, 3 months ago (2017-08-25 09:05:40 UTC) #2

https://codereview.chromium.org/3003263002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/3003263002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/parser/parser.dart:2413: token =
parseNativeClause(nativeToken);
I think the problem is how functions bodies are being skipped in
ClassMemberParser (and thus DietParser). 

If I'm right, the solution should be to move this logic to parseFunctionBody and
update skipFunctionBody to generate the native event.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages