Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart

Issue 3003233002: flag to limit file and package URI completion suggestions (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart
index 1cf49b7a2779dc5e48908a593ddd15be2488fa82..59c0f2befbe4e7a63df92ce371e57c4c42c9e9dc 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart
@@ -23,6 +23,15 @@ import 'package:path/src/context.dart';
class UriContributor extends DartCompletionContributor {
_UriSuggestionBuilder builder;
+ /**
+ * A flag indicating whether file: and package: URI suggestions should
+ * be included in the list of completion suggestions.
+ */
+ // TODO(danrubel): remove this flag and related functionality
+ // once the UriContributor limits file: and package: URI suggestions
+ // to only those paths within context roots.
+ static bool suggestFilePaths = true;
+
@override
Future<List<CompletionSuggestion>> computeSuggestions(
DartCompletionRequest request) async {
@@ -95,13 +104,17 @@ class _UriSuggestionBuilder extends SimpleAstVisitor {
String partialUri = _extractPartialUri(node);
if (partialUri != null) {
_addDartSuggestions();
- _addPackageSuggestions(partialUri);
- _addFileSuggestions(partialUri);
+ if (UriContributor.suggestFilePaths) {
+ _addPackageSuggestions(partialUri);
+ _addFileSuggestions(partialUri);
+ }
}
} else if (parent is PartDirective && parent.uri == node) {
String partialUri = _extractPartialUri(node);
if (partialUri != null) {
- _addFileSuggestions(partialUri);
+ if (UriContributor.suggestFilePaths) {
+ _addFileSuggestions(partialUri);
+ }
}
}
}

Powered by Google App Engine
This is Rietveld 408576698