flag to limit file and package URI completion suggestions

pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:core';
 
 import 'package:analysis_server/src/protocol_server.dart'
     show CompletionSuggestion, CompletionSuggestionKind;
 import 'package:analysis_server/src/provisional/completion/dart/completion_dart.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/generated/sdk.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:path/path.dart' show posix;
 import 'package:path/src/context.dart';
 
 /**
  * A contributor for calculating uri suggestions
  * for import and part directives.
  */
 class UriContributor extends DartCompletionContributor {
   _UriSuggestionBuilder builder;
 
+  /**
+   * A flag indicating whether file: and package: URI suggestions should
+   * be included in the list of completion suggestions.
+   */
+  // TODO(danrubel): remove this flag and related functionality
+  // once the UriContributor limits file: and package: URI suggestions
+  // to only those paths within context roots.
+  static bool suggestFilePaths = true;
+
   @override
   Future<List<CompletionSuggestion>> computeSuggestions(
       DartCompletionRequest request) async {
     builder = new _UriSuggestionBuilder(request);
     request.target.containingNode.accept(builder);
     return builder.suggestions;
   }
 }
 
 class _UriSuggestionBuilder extends SimpleAstVisitor {
@@ skipping 52 matching lines @@
     }
   }
 
   @override
   visitSimpleStringLiteral(SimpleStringLiteral node) {
     AstNode parent = node.parent;
     if (parent is NamespaceDirective && parent.uri == node) {
       String partialUri = _extractPartialUri(node);
       if (partialUri != null) {
         _addDartSuggestions();
-        _addPackageSuggestions(partialUri);
-        _addFileSuggestions(partialUri);
+        if (UriContributor.suggestFilePaths) {
+          _addPackageSuggestions(partialUri);
+          _addFileSuggestions(partialUri);
+        }
       }
     } else if (parent is PartDirective && parent.uri == node) {
       String partialUri = _extractPartialUri(node);
       if (partialUri != null) {
-        _addFileSuggestions(partialUri);
+        if (UriContributor.suggestFilePaths) {
+          _addFileSuggestions(partialUri);
+        }
       }
     }
   }
 
   void _addDartSuggestions() {
     _addSuggestion('dart:');
     SourceFactory factory = request.sourceFactory;
     for (SdkLibrary lib in factory.dartSdk.sdkLibraries) {
       if (!lib.isInternal && !lib.isImplementation) {
         if (!lib.shortName.startsWith('dart:_')) {
@@ skipping 105 matching lines @@
   }
 
   String _extractPartialUri(SimpleStringLiteral node) {
     if (request.offset < node.contentsOffset) {
       return null;
     }
     return node.literal.lexeme.substring(
         node.contentsOffset - node.offset, request.offset - node.offset);
   }
 }