content/renderer/render_view_impl.h - Issue 300323005: Route selection bounds updates through the compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 300323005: Route selection bounds updates through the compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Defer selection updates until after compositor scheduling Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/gpu/render_widget_compositor.cc ('K') | « content/renderer/gpu/render_widget_compositor.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index 0b2d9aaf68bfedc40be9048b5cb2e4dd81b2352d..a2ae67c241bc264d5d8c110eed0765a0bb8be5b2 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -554,7 +554,7 @@ class CONTENT_EXPORT RenderViewImpl

const std::vector<char>& color_profile) OVERRIDE;

virtual void OnOrientationChange() OVERRIDE;

virtual ui::TextInputType GetTextInputType() OVERRIDE;

- virtual void GetSelectionBounds(gfx::Rect* start, gfx::Rect* end) OVERRIDE;

+ virtual bool GetSelectionBounds(gfx::Rect* start, gfx::Rect* end) OVERRIDE;

#if defined(OS_MACOSX) || defined(USE_AURA)

virtual void GetCompositionCharacterBounds(

std::vector<gfx::Rect>* character_bounds) OVERRIDE;

« content/renderer/gpu/render_widget_compositor.cc ('K') | « content/renderer/gpu/render_widget_compositor.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »