Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 300323005: Route selection bounds updates through the compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Defer selection updates until after compositor scheduling Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 536 matching lines...) Expand 10 before | Expand all | Expand 10 after
547 int selection_start, 547 int selection_start,
548 int selection_end) OVERRIDE; 548 int selection_end) OVERRIDE;
549 virtual void OnImeConfirmComposition(const base::string16& text, 549 virtual void OnImeConfirmComposition(const base::string16& text,
550 const gfx::Range& replacement_range, 550 const gfx::Range& replacement_range,
551 bool keep_selection) OVERRIDE; 551 bool keep_selection) OVERRIDE;
552 virtual void SetDeviceScaleFactor(float device_scale_factor) OVERRIDE; 552 virtual void SetDeviceScaleFactor(float device_scale_factor) OVERRIDE;
553 virtual bool SetDeviceColorProfile( 553 virtual bool SetDeviceColorProfile(
554 const std::vector<char>& color_profile) OVERRIDE; 554 const std::vector<char>& color_profile) OVERRIDE;
555 virtual void OnOrientationChange() OVERRIDE; 555 virtual void OnOrientationChange() OVERRIDE;
556 virtual ui::TextInputType GetTextInputType() OVERRIDE; 556 virtual ui::TextInputType GetTextInputType() OVERRIDE;
557 virtual void GetSelectionBounds(gfx::Rect* start, gfx::Rect* end) OVERRIDE; 557 virtual bool GetSelectionBounds(gfx::Rect* start, gfx::Rect* end) OVERRIDE;
558 #if defined(OS_MACOSX) || defined(USE_AURA) 558 #if defined(OS_MACOSX) || defined(USE_AURA)
559 virtual void GetCompositionCharacterBounds( 559 virtual void GetCompositionCharacterBounds(
560 std::vector<gfx::Rect>* character_bounds) OVERRIDE; 560 std::vector<gfx::Rect>* character_bounds) OVERRIDE;
561 virtual void GetCompositionRange(gfx::Range* range) OVERRIDE; 561 virtual void GetCompositionRange(gfx::Range* range) OVERRIDE;
562 #endif 562 #endif
563 virtual bool CanComposeInline() OVERRIDE; 563 virtual bool CanComposeInline() OVERRIDE;
564 virtual void DidCommitCompositorFrame() OVERRIDE; 564 virtual void DidCommitCompositorFrame() OVERRIDE;
565 virtual void InstrumentWillBeginFrame(int frame_id) OVERRIDE; 565 virtual void InstrumentWillBeginFrame(int frame_id) OVERRIDE;
566 virtual void InstrumentDidBeginFrame() OVERRIDE; 566 virtual void InstrumentDidBeginFrame() OVERRIDE;
567 virtual void InstrumentDidCancelFrame() OVERRIDE; 567 virtual void InstrumentDidCancelFrame() OVERRIDE;
(...skipping 616 matching lines...) Expand 10 before | Expand all | Expand 10 after
1184 // use the Observer interface to filter IPC messages and receive frame change 1184 // use the Observer interface to filter IPC messages and receive frame change
1185 // notifications. 1185 // notifications.
1186 // --------------------------------------------------------------------------- 1186 // ---------------------------------------------------------------------------
1187 1187
1188 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1188 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1189 }; 1189 };
1190 1190
1191 } // namespace content 1191 } // namespace content
1192 1192
1193 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1193 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698