Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 3002943002: [telemetry_mini] Add story runner options (Closed)

Created:
3 years, 4 months ago by perezju
Modified:
3 years, 4 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[telemetry_mini] Add story runner options Add a small story runner and options to pick which stories to run. Defaults to running all (both!) stories, one after the other. BUG=chromium:752963 Review-Url: https://codereview.chromium.org/3002943002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1d62c7dbdf4a22f2bfac00efc8d81b669ebb9b23

Patch Set 1 #

Total comments: 4

Patch Set 2 : just --repeat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -87 lines) Patch
M experimental/telemetry_mini/android_go_stories.py View 1 8 chunks +123 lines, -78 lines 0 comments Download
M experimental/telemetry_mini/telemetry_mini.py View 1 6 chunks +37 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
perezju
https://codereview.chromium.org/3002943002/diff/1/experimental/telemetry_mini/android_go_stories.py File experimental/telemetry_mini/android_go_stories.py (left): https://codereview.chromium.org/3002943002/diff/1/experimental/telemetry_mini/android_go_stories.py#oldcode34 experimental/telemetry_mini/android_go_stories.py:34: class ProcessWatcher(object): Did not changed any of this code. ...
3 years, 4 months ago (2017-08-18 11:30:34 UTC) #2
nednguyen
lgtm https://codereview.chromium.org/3002943002/diff/1/experimental/telemetry_mini/android_go_stories.py File experimental/telemetry_mini/android_go_stories.py (right): https://codereview.chromium.org/3002943002/diff/1/experimental/telemetry_mini/android_go_stories.py#newcode234 experimental/telemetry_mini/android_go_stories.py:234: ' (default: %(default)d)') I would just name this ...
3 years, 4 months ago (2017-08-18 14:00:32 UTC) #3
perezju
https://codereview.chromium.org/3002943002/diff/1/experimental/telemetry_mini/android_go_stories.py File experimental/telemetry_mini/android_go_stories.py (right): https://codereview.chromium.org/3002943002/diff/1/experimental/telemetry_mini/android_go_stories.py#newcode234 experimental/telemetry_mini/android_go_stories.py:234: ' (default: %(default)d)') On 2017/08/18 14:00:32, nednguyen wrote: > ...
3 years, 4 months ago (2017-08-18 14:09:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3002943002/20001
3 years, 4 months ago (2017-08-18 14:09:12 UTC) #7
commit-bot: I haz the power
3 years, 4 months ago (2017-08-18 14:36:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698