Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 300283003: FastCloneShallowArrayStub should not be used it the length of the array is too big as it could even… (Closed)

Created:
6 years, 6 months ago by Igor Sheludko
Modified:
6 years, 6 months ago
Reviewers:
danno, Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

FastCloneShallowArrayStub should not be used it the length of the array is too big as it could eventually exceed the allowed size limit for manually folded allocations. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 6 months ago (2014-05-28 14:25:17 UTC) #1
Toon Verwaest
lgtm
6 years, 6 months ago (2014-05-28 16:00:08 UTC) #2
Igor Sheludko
6 years, 6 months ago (2014-05-28 16:01:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21573 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698