src/arm/full-codegen-arm.cc - Issue 300283003: FastCloneShallowArrayStub should not be used it the length of the array is too big as it could even…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/full-codegen-arm.cc

Issue 300283003: FastCloneShallowArrayStub should not be used it the length of the array is too big as it could even… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/full-codegen-arm.cc

diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc

index ccde8b6b227901c07fd5be6e9beb1d5537400963..5e3b62bf121d743a1903de347b0088cfb79958d1 100644

--- a/src/arm/full-codegen-arm.cc

+++ b/src/arm/full-codegen-arm.cc

@@ -1802,7 +1802,7 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {

__ ldr(r3, FieldMemOperand(r3, JSFunction::kLiteralsOffset));

__ mov(r2, Operand(Smi::FromInt(expr->literal_index())));

__ mov(r1, Operand(constant_elements));

- if (expr->depth() > 1) {

+ if (expr->depth() > 1 || length > JSObject::kInitialMaxFastElementArray) {

__ mov(r0, Operand(Smi::FromInt(flags)));

__ Push(r3, r2, r1, r0);

__ CallRuntime(Runtime::kHiddenCreateArrayLiteral, 4);

« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »