Issue 300283002: Introduce FieldIndex to unify and abstract property/field offset

Issue 300283002: Introduce FieldIndex to unify and abstract property/field offset (Closed)

Created:
6 years, 6 months ago by danno

Modified:
6 years, 6 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reland 21720: Introduce FieldIndex to unify and abstract property/field offset R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21746

Patch Set 9 : Fix 64-bit builds #

Patch Set 11 : Review feedback #

Patch Set 12 : Fix mutable boxed double runtime function #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+467 lines, -350 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1 2 3 4 5 6 7 8	7 chunks	+12 lines, -27 lines	0 comments	Download
M	src/arm64/stub-cache-arm64.cc	View	1 2 3 4 5 6 7 8	7 chunks	+12 lines, -27 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 2 3 4 5 6 7 8 9 10	3 chunks	+7 lines, -4 lines	0 comments	Download
M	src/code-stubs.h	View	1 2 3 4 5 6 7 8 9 10	3 chunks	+17 lines, -33 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View	1 2 3 4 5 6 7 8 9 10	5 chunks	+14 lines, -17 lines	0 comments	Download
M	src/deoptimizer.cc	View	1 2 3 4 5 6	2 chunks	+4 lines, -2 lines	0 comments	Download
A	src/field-index.h	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+123 lines, -0 lines	0 comments	Download
A	src/field-index.cc	View	1 2 3 4 5 6 7	1 chunk	+23 lines, -0 lines	0 comments	Download
A	src/field-index-inl.h	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+80 lines, -0 lines	0 comments	Download
M	src/heap-snapshot-generator.cc	View	1 2 3 4 5 6	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 2 3 4 5 6 7 8	5 chunks	+12 lines, -27 lines	0 comments	Download
M	src/ic.h	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/ic.cc	View	1 2 3 4 5 6 7 8 9 10 11	4 chunks	+11 lines, -12 lines	0 comments	Download
M	src/json-parser.h	View	1 2 3 4 5 6	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/json-stringifier.h	View	1 2 3 4 5 6	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/objects.h	View	1 2 3 4 5 6 7 8 9 10 11	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/objects.cc	View	1 2 3 4 5 6 7 8 9 10 11	13 chunks	+23 lines, -24 lines	0 comments	Download
M	src/objects-debug.cc	View	1 2 3 4 5 6	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View	1 2 3 4 5 6 7 8 9 10	3 chunks	+10 lines, -16 lines	0 comments	Download
M	src/objects-printer.cc	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/property.h	View	1 2 3 4 5 6 7	4 chunks	+5 lines, -53 lines	0 comments	Download
M	src/property.cc	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1 2 3 4 5 6 7 8 9 10 11	6 chunks	+26 lines, -20 lines	0 comments	Download
M	src/string-stream.cc	View	1 2 3 4 5 6	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/stub-cache.h	View	1 2 3 4 5 6	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/stub-cache.cc	View	1 2 3 4 5 6 9 10	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/utils.h	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 2 3 4 5 6 7 8	4 chunks	+12 lines, -27 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 2 3 4 5 6	3 chunks	+14 lines, -8 lines	0 comments	Download
A +	test/mjsunit/outobject-double-for-in.js	View	1 2 3 4 5 6 7 8 9 10 11	1 chunk	+32 lines, -29 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 2 3 4 5 6 7 8 9 10 11	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

Nice cleanup! LGTM. Just some small comments. https://codereview.chromium.org/300283002/diff/180001/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/300283002/diff/180001/src/code-stubs.h#newcode935 src/code-stubs.h:935: EncodedLoadFieldByIndexBits::encode(property_index_key); 4-space ...

6 years, 6 months ago (2014-06-06 12:00:33 UTC) #2

danno

Committed patchset #11 manually as r21720 (presubmit successful).

6 years, 6 months ago (2014-06-06 14:06:30 UTC) #3

danno

Feedback addressed, landing. https://codereview.chromium.org/300283002/diff/180001/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/300283002/diff/180001/src/code-stubs.h#newcode935 src/code-stubs.h:935: EncodedLoadFieldByIndexBits::encode(property_index_key); On 2014/06/06 12:00:32, Toon Verwaest ...

6 years, 6 months ago (2014-06-06 14:09:57 UTC) #4

danno

6 years, 6 months ago (2014-06-10 14:01:38 UTC) #7

Message was sent while issue was closed.

Committed patchset #12 manually as r21746 (presubmit successful).

Expand Messages | Collapse Messages