Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 300273002: Report only one input latency metric mean_input_event_latency (Closed)

Created:
6 years, 7 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 6 months ago
Reviewers:
nduca
CC:
chromium-reviews, telemetry+watch_chromium.org, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Report only one input latency metric mean_input_event_latency As telemetry result is mainly meant for monitoring regression, exposing different types of input latency, e.g. scroll/mouse/touch latency as we currently do, does not add more benefit to this purpose but instead adds more confusion for people when they look at the different input latency metrics. Lets only report one input latency metric mean_input_event_latency, which is derived from all input events which have event creation timestamp and swap buffer timestamp, regardless of its event type. BUG=378027 TEST=run telemetry smoothness tests and see only one mean_input_event_latency is reported. unittests pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274390

Patch Set 1 #

Patch Set 2 : better formatting #

Patch Set 3 : also search latency slice in renderer process since that's where plugin input event's latency is ge… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -208 lines) Patch
M tools/perf/measurements/smoothness_unittest.py View 1 chunk +5 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_stats.py View 1 2 5 chunks +49 lines, -87 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py View 9 chunks +26 lines, -81 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness.py View 1 chunk +10 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yufeng Shen (Slow to review)
6 years, 7 months ago (2014-05-27 22:52:08 UTC) #1
nduca
lgtm!!!
6 years, 6 months ago (2014-06-02 20:37:48 UTC) #2
Yufeng Shen (Slow to review)
The CQ bit was checked by miletus@chromium.org
6 years, 6 months ago (2014-06-02 20:58:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/300273002/40001
6 years, 6 months ago (2014-06-02 20:59:47 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 00:45:43 UTC) #5
Message was sent while issue was closed.
Change committed as 274390

Powered by Google App Engine
This is Rietveld 408576698