Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: tools/perf/measurements/smoothness_unittest.py

Issue 300273002: Report only one input latency metric mean_input_event_latency (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: also search latency slice in renderer process since that's where plugin input event's latency is ge… Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/web_perf/metrics/rendering_stats.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import sys 4 import sys
5 5
6 from measurements import smoothness 6 from measurements import smoothness
7 from telemetry.core import wpr_modes 7 from telemetry.core import wpr_modes
8 from telemetry.page import page 8 from telemetry.page import page
9 from telemetry.page import page_measurement_unittest_base 9 from telemetry.page import page_measurement_unittest_base
10 # pylint: disable=W0401,W0614 10 # pylint: disable=W0401,W0614
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 self.assertGreater(mean_frame_time[0].GetRepresentativeNumber(), 0) 99 self.assertGreater(mean_frame_time[0].GetRepresentativeNumber(), 0)
100 100
101 jank = results.FindAllPageSpecificValuesNamed('jank') 101 jank = results.FindAllPageSpecificValuesNamed('jank')
102 self.assertEquals(len(jank), 1) 102 self.assertEquals(len(jank), 1)
103 self.assertGreater(jank[0].GetRepresentativeNumber(), 0) 103 self.assertGreater(jank[0].GetRepresentativeNumber(), 0)
104 104
105 mostly_smooth = results.FindAllPageSpecificValuesNamed('mostly_smooth') 105 mostly_smooth = results.FindAllPageSpecificValuesNamed('mostly_smooth')
106 self.assertEquals(len(mostly_smooth), 1) 106 self.assertEquals(len(mostly_smooth), 1)
107 self.assertGreaterEqual(mostly_smooth[0].GetRepresentativeNumber(), 0) 107 self.assertGreaterEqual(mostly_smooth[0].GetRepresentativeNumber(), 0)
108 108
109 mean_mouse_wheel_latency = results.FindAllPageSpecificValuesNamed( 109 mean_input_event_latency = results.FindAllPageSpecificValuesNamed(
110 'mean_mouse_wheel_latency') 110 'mean_input_event_latency')
111 if mean_mouse_wheel_latency: 111 if mean_input_event_latency:
112 self.assertEquals(len(mean_mouse_wheel_latency), 1) 112 self.assertEquals(len(mean_input_event_latency), 1)
113 self.assertGreater( 113 self.assertGreater(
114 mean_mouse_wheel_latency[0].GetRepresentativeNumber(), 0) 114 mean_input_event_latency[0].GetRepresentativeNumber(), 0)
115
116 mean_touch_scroll_latency = results.FindAllPageSpecificValuesNamed(
117 'mean_touch_scroll_latency')
118 if mean_touch_scroll_latency:
119 self.assertEquals(len(mean_touch_scroll_latency), 1)
120 self.assertGreater(
121 mean_touch_scroll_latency[0].GetRepresentativeNumber(), 0)
122 115
123 def testSmoothnessForPageWithNoGesture(self): 116 def testSmoothnessForPageWithNoGesture(self):
124 ps = self.CreateEmptyPageSet() 117 ps = self.CreateEmptyPageSet()
125 ps.AddPage(AnimatedPage(ps)) 118 ps.AddPage(AnimatedPage(ps))
126 119
127 measurement = smoothness.Smoothness() 120 measurement = smoothness.Smoothness()
128 results = self.RunMeasurement(measurement, ps, options=self._options) 121 results = self.RunMeasurement(measurement, ps, options=self._options)
129 self.assertEquals(0, len(results.failures)) 122 self.assertEquals(0, len(results.failures))
130 123
131 mostly_smooth = results.FindAllPageSpecificValuesNamed('mostly_smooth') 124 mostly_smooth = results.FindAllPageSpecificValuesNamed('mostly_smooth')
132 self.assertEquals(len(mostly_smooth), 1) 125 self.assertEquals(len(mostly_smooth), 1)
133 self.assertGreaterEqual(mostly_smooth[0].GetRepresentativeNumber(), 0) 126 self.assertGreaterEqual(mostly_smooth[0].GetRepresentativeNumber(), 0)
134 127
135 def testCleanUpTrace(self): 128 def testCleanUpTrace(self):
136 self.TestTracingCleanedUp(smoothness.Smoothness, self._options) 129 self.TestTracingCleanedUp(smoothness.Smoothness, self._options)
OLDNEW
« no previous file with comments | « no previous file | tools/telemetry/telemetry/web_perf/metrics/rendering_stats.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698