Fix insertion of imports when there are no existing directives (issue 30430)

Fix insertion of imports when there are no existing directives (issue 30430)

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/eaf779ba1ebd6916d50df00f55f99a0db564148c

[Brian Wilkerson, 2017-08-14 18:30:21]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-08-14 18:37:51]

LGTM

https://codereview.chromium.org/3002643002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/computer/import_elements_computer.dart (right):

https://codereview.chromium.org/3002643002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/import_elements_computer.dart:353:
_InsertionDescription _offsetForInsertion(String importUri) {
Maybe rename the method, it returns not just the offset now.

https://codereview.chromium.org/3002643002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/import_elements_computer.dart:429:
_InsertionDescription(this.offset, this.newLinesBefore, this.newLinesAfter);
Maybe reorder the parameters to correspond to the order of the fields.
Well, or reorder the fields.

https://codereview.chromium.org/3002643002/diff/1/pkg/analysis_server/test/sr...
File pkg/analysis_server/test/src/computer/import_elements_computer_test.dart
(right):

https://codereview.chromium.org/3002643002/diff/1/pkg/analysis_server/test/sr...
pkg/analysis_server/test/src/computer/import_elements_computer_test.dart:61:
test_createEdits_addImport_noDirectives() async {
Maybe also worth to add a test with parts.

[Brian Wilkerson, 2017-08-14 19:59:20]

https://codereview.chromium.org/3002643002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/computer/import_elements_computer.dart (right):

https://codereview.chromium.org/3002643002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/import_elements_computer.dart:353:
_InsertionDescription _offsetForInsertion(String importUri) {
Done

https://codereview.chromium.org/3002643002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/import_elements_computer.dart:429:
_InsertionDescription(this.offset, this.newLinesBefore, this.newLinesAfter);
Reworked to use named parameters

https://codereview.chromium.org/3002643002/diff/1/pkg/analysis_server/test/sr...
File pkg/analysis_server/test/src/computer/import_elements_computer_test.dart
(right):

https://codereview.chromium.org/3002643002/diff/1/pkg/analysis_server/test/sr...
pkg/analysis_server/test/src/computer/import_elements_computer_test.dart:61:
test_createEdits_addImport_noDirectives() async {
Absolutely. In fact, I think you found a bug. But I think the bug is outside
this class, so this isn't the right place for the test. Hence, I'll add it in a
separate CL.

[Brian Wilkerson, 2017-08-14 20:05:44]

ptal

[scheglov, 2017-08-14 20:06:52]

LGTM

[Brian Wilkerson, 2017-08-14 20:33:02]

Description was changed from

==========
Fix insertion of imports when there are no existing directives (issue 30430)
==========

to

==========
Fix insertion of imports when there are no existing directives (issue 30430)

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/eaf779ba1ebd6916d50df00f55f99a0db564148c
==========

[Brian Wilkerson, 2017-08-14 20:33:03]

Committed patchset #2 (id:20001) manually as
eaf779ba1ebd6916d50df00f55f99a0db564148c (presubmit successful).