Fix insertion of imports when there are no existing directives (issue 30430)

pkg/analysis_server/lib/src/computer/import_elements_computer.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analysis_server/protocol/protocol_generated.dart';
 import 'package:analyzer/dart/analysis/results.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/ast_factory.dart';
@@ skipping 59 matching lines @@
         if (matchingImports.isEmpty) {
           //
           // The required library is not being imported with a matching prefix,
           // so we need to add an import.
           //
           File importedFile = resourceProvider.getFile(importedElements.path);
           Uri uri = sourceFactory.restoreUri(importedFile.createSource());
           Source importedSource = importedFile.createSource(uri);
           String importUri =
               _getLibrarySourceUri(libraryElement, importedSource);
-          int offset = _offsetForInsertion(importUri);
-          builder.addInsertion(offset, (DartEditBuilder builder) {
-            builder.writeln();
+          _InsertionDescription description = _offsetForInsertion(importUri);
+          builder.addInsertion(description.offset, (DartEditBuilder builder) {
+            for (int i = 0; i < description.newLinesBefore; i++) {
+              builder.writeln();
+            }
             builder.write("import '");
             builder.write(importUri);
             builder.write("'");
             if (importedElements.prefix.isNotEmpty) {
               builder.write(' as ');
               builder.write(importedElements.prefix);
             }
             builder.write(';');
+            for (int i = 0; i < description.newLinesAfter; i++) {
+              builder.writeln();
+            }
           });
         } else {
           //
           // There are some imports of the library with a matching prefix. We
           // need to determine whether the names are already visible or whether
           // we need to make edits to make them visible.
           //
           // Compute the edits that need to be made.
           //
           Map<ImportDirective, _ImportUpdate> updateMap =
@@ skipping 237 matching lines @@
             importedElements.path &&
         (import.prefix?.name ?? '') == importedElements.prefix;
   }
 
   /**
    * Return the offset at which an import of the given [importUri] should be
    * inserted.
    *
    * Partially copied from DartFileEditBuilderImpl.
    */
-  int _offsetForInsertion(String importUri) {
-    // TODO(brianwilkerson) Fix this to find the right location.
-    // See DartFileEditBuilderImpl._addLibraryImports for inspiration.
+  _InsertionDescription _offsetForInsertion(String importUri) {

[scheglov, 2017/08/14 18:37:51]

Maybe rename the method, it returns not just the offset now.

[Brian Wilkerson, 2017/08/14 19:59:20]

Done

     CompilationUnit unit = libraryResult.unit;
     LibraryDirective libraryDirective;
     List<ImportDirective> importDirectives = <ImportDirective>[];
+    List<Directive> otherDirectives = <Directive>[];
     for (Directive directive in unit.directives) {
       if (directive is LibraryDirective) {
         libraryDirective = directive;
       } else if (directive is ImportDirective) {
         importDirectives.add(directive);
+      } else {
+        otherDirectives.add(directive);
       }
     }
     if (importDirectives.isEmpty) {
       if (libraryDirective == null) {
-        return 0;
+        if (otherDirectives.isEmpty) {
+          // TODO(brianwilkerson) Insert after any non-doc comments.
+          return new _InsertionDescription(0, 0, 2);
+        }
+        return new _InsertionDescription(otherDirectives[0].offset, 0, 2);
       }
-      return libraryDirective.end;
+      return new _InsertionDescription(libraryDirective.end, 2, 0);
     }
-    return importDirectives.last.end;
+    // TODO(brianwilkerson) Fix this to find the right location.
+    // See DartFileEditBuilderImpl._addLibraryImports for inspiration.
+    return new _InsertionDescription(importDirectives.last.end, 1, 0);
   }
 }
 
 /**
  * Information about how a given import directive needs to be updated in order
  * to make the required names visible.
  */
 class _ImportUpdate {
   /**
    * The import directive to be updated.
@@ skipping 23 matching lines @@
     namesToShow.add(name);
   }
 
   /**
    * Record that the given [name] needs to be removed from hide combinators.
    */
   void unhide(String name) {
     namesToUnhide.add(name);
   }
 }
+
+class _InsertionDescription {
+  final int newLinesBefore;
+  final int offset;
+  final int newLinesAfter;
+
+  _InsertionDescription(this.offset, this.newLinesBefore, this.newLinesAfter);

[scheglov, 2017/08/14 18:37:51]

Maybe reorder the parameters to correspond to the order of the fields.
Well, or reorder the fields.

[Brian Wilkerson, 2017/08/14 19:59:20]

Reworked to use named parameters

+}