Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3002313002: Use KernelTypeGraphBuilder in KernelInferrerEngine (Closed)

Created:
3 years, 3 months ago by Johnni Winther
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use KernelTypeGraphBuilder in KernelInferrerEngine + parameterization of LocalsHandler and friends. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/65956edb231019ba825e2f7251cd2cfacc8b3bdb

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -203 lines) Patch
M pkg/compiler/lib/src/commandline_options.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 4 chunks +7 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/ast_inferrer_engine.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 14 chunks +39 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder_kernel.dart View 5 chunks +37 lines, -55 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 4 chunks +6 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart View 1 7 chunks +138 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/locals_handler.dart View 20 chunks +60 lines, -51 lines 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 6 chunks +9 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_model/locals.dart View 4 chunks +35 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/options.dart View 5 chunks +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/element_world_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 4 chunks +15 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 5 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
3 years, 3 months ago (2017-08-25 16:46:28 UTC) #2
Johnni Winther
ping
3 years, 3 months ago (2017-08-28 07:25:38 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/3002313002/diff/1/pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart File pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart (right): https://codereview.chromium.org/3002313002/diff/1/pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart#newcode220 pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart:220: if (functionNode.parent is ir.Member) {} else if (functionNode.parent ...
3 years, 3 months ago (2017-08-28 22:16:41 UTC) #4
Johnni Winther
https://codereview.chromium.org/3002313002/diff/1/pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart File pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart (right): https://codereview.chromium.org/3002313002/diff/1/pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart#newcode220 pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart:220: if (functionNode.parent is ir.Member) {} else if (functionNode.parent On ...
3 years, 3 months ago (2017-08-29 07:59:03 UTC) #5
Johnni Winther
3 years, 3 months ago (2017-08-29 08:00:08 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
65956edb231019ba825e2f7251cd2cfacc8b3bdb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698