Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: pkg/compiler/lib/src/inferrer/inferrer_engine.dart

Issue 3002313002: Use KernelTypeGraphBuilder in KernelInferrerEngine (Closed)
Patch Set: Updated cf. comments. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/inferrer/inferrer_engine.dart
diff --git a/pkg/compiler/lib/src/inferrer/inferrer_engine.dart b/pkg/compiler/lib/src/inferrer/inferrer_engine.dart
index 4636559ce66edc7fd2578f9db7bee796723c9722..3fa9269d29c5d3d0968a3a04e8646087cf00314b 100644
--- a/pkg/compiler/lib/src/inferrer/inferrer_engine.dart
+++ b/pkg/compiler/lib/src/inferrer/inferrer_engine.dart
@@ -69,11 +69,6 @@ abstract class InferrerEngine<T> {
TypeSystem<T> get types;
Map<T, TypeInformation> get concreteTypes;
- /// Parallel structure for concreteTypes.
- // TODO(efortuna): Remove concreteTypes and/or parameterize InferrerEngine by
- // ir.Node or ast.Node type. Then remove this in favor of `concreteTypes`.
- Map<ir.Node, TypeInformation> get concreteKernelTypes;
-
FunctionEntity get mainElement;
void runOverAllElements();
@@ -633,7 +628,8 @@ abstract class InferrerEngineImpl<T> extends InferrerEngine<T> {
/// Call [analyze] for all live members.
void analyzeAllElements() {
- sortMembers(compiler, computeMemberSize).forEach((MemberEntity member) {
+ sortMembers(closedWorld.processedMembers, computeMemberSize)
+ .forEach((MemberEntity member) {
if (compiler.shouldPrintProgress) {
reporter.log('Added $addedInGraph elements in inferencing graph.');
compiler.progress.reset();
@@ -1119,9 +1115,9 @@ abstract class InferrerEngineImpl<T> extends InferrerEngine<T> {
// to get the same results for [ListTracer] compared to the
// [SimpleTypesInferrer].
static Iterable<MemberEntity> sortMembers(
- Compiler compiler, int computeSize(MemberEntity member)) {
+ Iterable<MemberEntity> members, int computeSize(MemberEntity member)) {
Map<int, Set<MemberEntity>> methodSizes =
- groupMembers(compiler, computeSize);
+ groupMembers(members, computeSize);
int max = methodSizes.keys.fold(0, (a, b) => a > b ? a : b);
List<MemberEntity> result = <MemberEntity>[];
for (int i = 0; i <= max; i++) {
@@ -1132,10 +1128,9 @@ abstract class InferrerEngineImpl<T> extends InferrerEngine<T> {
}
static Map<int, Set<MemberEntity>> groupMembers(
- Compiler compiler, int computeSize(MemberEntity member)) {
+ Iterable<MemberEntity> members, int computeSize(MemberEntity member)) {
Map<int, Set<MemberEntity>> methodSizes = <int, Set<MemberEntity>>{};
- compiler.enqueuer.resolution.processedEntities
- .forEach((MemberEntity element) {
+ members.forEach((MemberEntity element) {
if (element.isAbstract) return;
// Put the other operators in buckets by size, later to be added in
// size order.
« no previous file with comments | « pkg/compiler/lib/src/inferrer/builder_kernel.dart ('k') | pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698