mojo/public/interfaces/bindings/tests/sample_interfaces.mojom - Issue 300223008: Add module annotation to specify the name of the java class for constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/bindings/tests/sample_interfaces.mojom

Issue 300223008: Add module annotation to specify the name of the java class for constants. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java ('k') | mojo/public/tools/bindings/generators/mojom_java_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/interfaces/bindings/tests/sample_interfaces.mojom

diff --git a/mojo/public/interfaces/bindings/tests/sample_interfaces.mojom b/mojo/public/interfaces/bindings/tests/sample_interfaces.mojom

index f2b1dc93dcac3ed6e2cb0a1913eeee5b09309832..a0dceb49b744bf7b6647d7e9a250022c814a368a 100644

--- a/mojo/public/interfaces/bindings/tests/sample_interfaces.mojom

+++ b/mojo/public/interfaces/bindings/tests/sample_interfaces.mojom

@@ -3,9 +3,12 @@

// found in the LICENSE file.

[JavaPackage="org.chromium.mojo.bindings.test.sample",

+ JavaConstantsClassName="InterfaceConstants",

Foo = "hello world"]

module sample {

+const uint64 kLong = (879+2)*5;

rmcilroy 2014/05/28 17:03:30 nit - spaces between binary operators. Could we a

viettrungluu 2014/05/28 19:10:26 Note that I'm going to remove all expressions shor

enum Enum {

ENUM_VALUE

};