Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java

Issue 300223008: Add module annotation to specify the name of the java class for constants. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java
diff --git a/mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java b/mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java
index 1c4807b1726a218fcf0a913a3c7d8ac03ed71584..e36b0d667dd6e3ba6195fe90b24ba49d269a461f 100644
--- a/mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java
+++ b/mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java
@@ -8,6 +8,7 @@ import android.test.suitebuilder.annotation.SmallTest;
import junit.framework.TestCase;
+import org.chromium.mojo.bindings.test.sample.InterfaceConstants;
import org.chromium.mojo.bindings.test.sample.SampleServiceConstants;
import java.lang.reflect.Field;
@@ -18,16 +19,23 @@ import java.lang.reflect.Modifier;
*/
public class BindingsTest extends TestCase {
+ private static void checkConstantField(Field field, Class<?> expectedClass)
+ {
+ assertEquals(expectedClass, field.getType());
+ assertEquals(Modifier.FINAL, field.getModifiers() & Modifier.FINAL);
+ assertEquals(Modifier.STATIC, field.getModifiers() & Modifier.STATIC);
+ }
+
/**
* Testing constants are correctly generated.
*/
@SmallTest
public void testConstants() throws NoSuchFieldException, SecurityException {
assertEquals(3, SampleServiceConstants.THREE);
- Field threeField = SampleServiceConstants.class.getField("THREE");
- assertEquals(byte.class, threeField.getType());
- assertEquals(Modifier.FINAL, threeField.getModifiers() & Modifier.FINAL);
- assertEquals(Modifier.STATIC, threeField.getModifiers() & Modifier.STATIC);
+ checkConstantField(SampleServiceConstants.class.getField("THREE"), byte.class);
+
+ assertEquals(881 * 5, InterfaceConstants.LONG);
+ checkConstantField(InterfaceConstants.class.getField("LONG"), long.class);
}
}

Powered by Google App Engine
This is Rietveld 408576698