[Telemetry] Add Nexus5x/Nexus6 webview disabling to StoryExpectations.

[Telemetry] Add Nexus5x/Nexus6 webview disabling to StoryExpectations.

Before this you could disable all nexus5x/6 devices or all webview. This
adds a composite test condition that will disable if multiple different
test conditions are met.

TBR=nednguyen@google.com
BUG=chromium:713222
Review-Url: https://codereview.chromium.org/3002183002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9ff44138889f634b723b5be30e6ecee31aa81a1b

[rnephew (Reviews Here), 2017-08-23 16:04:00]

rnephew@chromium.org changed reviewers:
+ charliea@chromium.org, nednguyen@google.com

[charliea (OOO until 10-5), 2017-08-23 17:43:02]

https://codereview.chromium.org/3002183002/diff/1/telemetry/telemetry/story/e...
File telemetry/telemetry/story/expectations.py (right):

https://codereview.chromium.org/3002183002/diff/1/telemetry/telemetry/story/e...
telemetry/telemetry/story/expectations.py:223: class
_TestConditionCompositeConditions(_TestCondition):
I wonder if it makes sense to call this something like
"_TestConditionLogicalAnd" or "_TestConditionMatchesAll" or
"_TestConditionSatisfiesAll"? Technically, an OR is a composite of two
conditions, but it's not what this composite does, which makes me think that
just "composite" might not be specific enough.

[rnephew (Reviews Here), 2017-08-23 17:45:13]

https://codereview.chromium.org/3002183002/diff/1/telemetry/telemetry/story/e...
File telemetry/telemetry/story/expectations.py (right):

https://codereview.chromium.org/3002183002/diff/1/telemetry/telemetry/story/e...
telemetry/telemetry/story/expectations.py:223: class
_TestConditionCompositeConditions(_TestCondition):
On 2017/08/23 17:43:02, charliea wrote:
> I wonder if it makes sense to call this something like
> "_TestConditionLogicalAnd" or "_TestConditionMatchesAll" or
> "_TestConditionSatisfiesAll"? Technically, an OR is a composite of two
> conditions, but it's not what this composite does, which makes me think that
> just "composite" might not be specific enough.

Done.

[charliea (OOO until 10-5), 2017-08-23 17:45:47]

lgtm

[rnephew (Reviews Here), 2017-08-23 17:45:56]

The CQ bit was checked by rnephew@chromium.org

[commit-bot: I haz the power, 2017-08-23 17:46:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-23 17:49:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-23 17:49:12]

Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[rnephew (Reviews Here), 2017-08-23 18:45:40]

Description was changed from

==========
[Telemetry] Add Nexus5x/Nexus6 webview disabling to StoryExpectations.

Before this you could disable all nexus5x/6 devices or all webview. This
adds a composite test condition that will disable if multiple different
test conditions are met.

BUG=chromium:713222
==========

to

==========
[Telemetry] Add Nexus5x/Nexus6 webview disabling to StoryExpectations.

Before this you could disable all nexus5x/6 devices or all webview. This
adds a composite test condition that will disable if multiple different
test conditions are met.

TBR=nednguyen@google.com
BUG=chromium:713222
==========

[rnephew (Reviews Here), 2017-08-23 18:45:44]

The CQ bit was checked by rnephew@chromium.org

[commit-bot: I haz the power, 2017-08-23 18:45:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-23 19:12:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1503513944657120,
"parent_rev": "a46a34394562d9766d7e41088de276d89d27c04e", "commit_rev":
"9ff44138889f634b723b5be30e6ecee31aa81a1b"}

[commit-bot: I haz the power, 2017-08-23 19:12:25]

Description was changed from

==========
[Telemetry] Add Nexus5x/Nexus6 webview disabling to StoryExpectations.

Before this you could disable all nexus5x/6 devices or all webview. This
adds a composite test condition that will disable if multiple different
test conditions are met.

TBR=nednguyen@google.com
BUG=chromium:713222
==========

to

==========
[Telemetry] Add Nexus5x/Nexus6 webview disabling to StoryExpectations.

Before this you could disable all nexus5x/6 devices or all webview. This
adds a composite test condition that will disable if multiple different
test conditions are met.

TBR=nednguyen@google.com
BUG=chromium:713222

Review-Url: https://codereview.chromium.org/3002183002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-08-23 19:12:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...