Issue 3001863002: Revert "[vm] Prevent non-fatal errors from causing timers to be dropped."

Issue 3001863002: Revert "[vm] Prevent non-fatal errors from causing timers to be dropped." (Closed)

Created:
3 years, 4 months ago by rmacnak

Modified:
3 years, 4 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org, yjbanov

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "[vm] Prevent non-fatal errors from causing timers to be dropped." This reverts commit 8692f618f6a71f3e47f6ecf18ab45a1fb0df696b. This change caused co19/LibTest/isolate/Isolate/spawn_A06_t06 to timeout. Committed: https://github.com/dart-lang/sdk/commit/c536c82521f4c6dbc831078367aee15060801eb1

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -35 lines)			Patch
	M	runtime/lib/timer_impl.dart	View		2 chunks	+1 line, -8 lines	0 comments	Download
	D	tests/isolate/non_fatal_exception_in_timer_callback_test.dart	View		1 chunk	+0 lines, -27 lines	0 comments	Download

Total messages: 5 (3 generated)

rmacnak

Committed patchset #1 (id:1) manually as c536c82521f4c6dbc831078367aee15060801eb1 (presubmit successful).

3 years, 4 months ago (2017-08-17 20:19:54 UTC) #4

Message was sent while issue was closed.

lgtm