Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: tests/isolate/non_fatal_exception_in_timer_callback_test.dart

Issue 3001863002: Revert "[vm] Prevent non-fatal errors from causing timers to be dropped." (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/timer_impl.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 import 'dart:async';
6 import 'dart:isolate';
7 import 'dart:io';
8
9 main() async {
10 Isolate.current.setErrorsFatal(false);
11
12 new Timer(const Duration(milliseconds: 10), () {
13 print("Timer 1");
14
15 // This unhandled exception should not prevent the second timer from firing.
16 throw "Oh no!";
17 });
18
19 new Timer.periodic(const Duration(milliseconds: 20), (_) {
20 print("Timer 2");
21 exit(0);
22 });
23
24 sleep(const Duration(milliseconds: 30)); //# sleep: ok
25 // With sleep: both timers are due at the same wakeup event.
26 // Without sleep: the timers get separate wakeup events.
27 }
OLDNEW
« no previous file with comments | « runtime/lib/timer_impl.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698