Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 300173002: [SyncFS] Handle unavailable ExtensionService case. (Closed)

Created:
6 years, 7 months ago by tzik
Modified:
6 years, 7 months ago
Reviewers:
peria, nhiroki
CC:
chromium-reviews, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi, nhiroki
Visibility:
Public.

Description

[SyncFS] Handle unavailable ExtensionService case. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273113

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc View 1 chunk +4 lines, -1 line 3 comments Download

Messages

Total messages: 14 (0 generated)
tzik
PTL, this causes crash on my local machine.
6 years, 7 months ago (2014-05-27 08:19:12 UTC) #1
peria
lgtm
6 years, 7 months ago (2014-05-27 08:21:25 UTC) #2
nhiroki
This is not related to this CL... but let me comment. https://codereview.chromium.org/300173002/diff/1/chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc File chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc (right): ...
6 years, 7 months ago (2014-05-27 09:04:32 UTC) #3
tzik
https://codereview.chromium.org/300173002/diff/1/chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc File chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc (right): https://codereview.chromium.org/300173002/diff/1/chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc#newcode84 chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc:84: if (!sync_service) On 2014/05/27 09:04:32, nhiroki wrote: > Is ...
6 years, 7 months ago (2014-05-27 12:54:12 UTC) #4
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 7 months ago (2014-05-27 12:54:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/300173002/1
6 years, 7 months ago (2014-05-27 12:54:34 UTC) #6
tzik
This is from r272483 (4 days ago). The DCHECK condition and NULL case handling were ...
6 years, 7 months ago (2014-05-27 14:45:27 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 16:53:15 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 16:59:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77978)
6 years, 7 months ago (2014-05-27 16:59:35 UTC) #10
nhiroki
LGTM (just in case)
6 years, 7 months ago (2014-05-28 01:15:36 UTC) #11
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 7 months ago (2014-05-28 01:35:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/300173002/1
6 years, 7 months ago (2014-05-28 01:36:45 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 02:39:45 UTC) #14
Message was sent while issue was closed. 
Change committed as 273113

Powered by Google App Engine
This is Rietveld 408576698