[SyncFS] Handle unavailable ExtensionService case.

chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.h"
 
 #include <map>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 13 matching lines @@
 using sync_file_system::SyncServiceState;
 
 namespace syncfs_internals {
 
 namespace {
 
 void ConvertExtensionStatusToDictionary(
     const base::WeakPtr<ExtensionService>& extension_service,
     const base::Callback<void(const base::ListValue&)>& callback,
     const std::map<GURL, std::string>& status_map) {
-  DCHECK(!extension_service);
+  if (!extension_service) {
+    callback.Run(base::ListValue());
+    return;
+  }
 
   base::ListValue list;
   for (std::map<GURL, std::string>::const_iterator itr = status_map.begin();
        itr != status_map.end();
        ++itr) {
     std::string extension_id = itr->first.HostNoBrackets();
 
     // Join with human readable extension name.
     const extensions::Extension* extension =
         extension_service->GetExtensionById(extension_id, true);
@@ skipping 26 matching lines @@
 }
 
 // static
 void ExtensionStatusesHandler::GetExtensionStatusesAsDictionary(
     Profile* profile,
     const base::Callback<void(const base::ListValue&)>& callback) {
   DCHECK(profile);
 
   sync_file_system::SyncFileSystemService* sync_service =
       SyncFileSystemServiceFactory::GetForProfile(profile);
   if (!sync_service)

[nhiroki, 2014/05/27 09:04:32]

Is it okay to ignore |callback|?

[tzik, 2014/05/27 12:54:12]

Hmm?
No. It should handle. Let me do later.

     return;
 
   ExtensionService* extension_service =
       extensions::ExtensionSystem::Get(profile)->extension_service();
   if (!extension_service)

[nhiroki, 2014/05/27 09:04:32]

ditto.

     return;
 
   sync_service->GetExtensionStatusMap(base::Bind(
       &ConvertExtensionStatusToDictionary,
       extension_service->AsWeakPtr(), callback));
 }
 
 void ExtensionStatusesHandler::GetExtensionStatuses(
     const base::ListValue* args) {
   DCHECK(args);
   GetExtensionStatusesAsDictionary(
       profile_,
       base::Bind(&ExtensionStatusesHandler::DidGetExtensionStatuses,
                  weak_ptr_factory_.GetWeakPtr()));
 }
 
 void ExtensionStatusesHandler::DidGetExtensionStatuses(
     const base::ListValue& list) {
   web_ui()->CallJavascriptFunction("ExtensionStatuses.onGetExtensionStatuses",
                                    list);
 }
 
 }  // namespace syncfs_internals