Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
3001663002:
Minor changes to TestVp8Impl. (Closed)
|
Created:
3 years, 4 months ago by åsapersson Modified:
3 years, 4 months ago Reviewers:
brandtr CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionMinor changes to TestVp8Impl.
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/3001663002
Cr-Commit-Position: refs/heads/master@{#19447}
Committed: https://chromium.googlesource.com/external/webrtc/+/aaaf2db253e0155403d9ac5925351af046ed0d7c
Patch Set 1 #
Total comments: 2
Patch Set 2 : address comment #Messages
Total messages: 27 (22 generated)
Description was changed from ========== s s BUG= ========== to ========== vp8_impl_unittest BUG=webrtc:6634 ==========
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Patchset #4 (id:60001) has been deleted
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #2 (id:100001) has been deleted
Patchset #1 (id:80001) has been deleted
Description was changed from ========== vp8_impl_unittest BUG=webrtc:6634 ========== to ========== Minor changes to TestVp8Impl. BUG=webrtc:6634 ==========
Patchset #1 (id:120001) has been deleted
asapersson@webrtc.org changed reviewers: + brandtr@webrtc.org
lgtm https://codereview.webrtc.org/3001663002/diff/140001/webrtc/modules/video_cod... File webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc (right): https://codereview.webrtc.org/3001663002/diff/140001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:62: memcpy(frame_buffer_.get(), encoded_frame._buffer, encoded_frame._length); RTC_DCHECK(frame_buffer_) ?
https://codereview.webrtc.org/3001663002/diff/140001/webrtc/modules/video_cod... File webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc (right): https://codereview.webrtc.org/3001663002/diff/140001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:62: memcpy(frame_buffer_.get(), encoded_frame._buffer, encoded_frame._length); On 2017/08/22 10:38:05, brandtr wrote: > RTC_DCHECK(frame_buffer_) ? Done.
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by asapersson@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org Link to the patchset: https://codereview.webrtc.org/3001663002/#ps160001 (title: "address comment")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 160001, "attempt_start_ts": 1503405233604140,
"parent_rev": "417989a8643d0d19052a87e95905b469d5ede173", "commit_rev":
"aaaf2db253e0155403d9ac5925351af046ed0d7c"}
Message was sent while issue was closed.
Description was changed from ========== Minor changes to TestVp8Impl. BUG=webrtc:6634 ========== to ========== Minor changes to TestVp8Impl. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/3001663002 Cr-Commit-Position: refs/heads/master@{#19447} Committed: https://chromium.googlesource.com/external/webrtc/+/aaaf2db253e0155403d9ac592... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:160001) as https://chromium.googlesource.com/external/webrtc/+/aaaf2db253e0155403d9ac592... |
