Source/core/editing/ReplaceSelectionCommand.cpp - Issue 300143012: Check nullable value before using it in ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ReplaceSelectionCommand.cpp

Issue 300143012: Check nullable value before using it in ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/ReplaceSelectionCommand.cpp

diff --git a/Source/core/editing/ReplaceSelectionCommand.cpp b/Source/core/editing/ReplaceSelectionCommand.cpp

index 43d1e195730fe480218b123c03c9c54be652b2d6..40b1c380a54ca46172fc35903e39817d3b08c41f 100644

--- a/Source/core/editing/ReplaceSelectionCommand.cpp

+++ b/Source/core/editing/ReplaceSelectionCommand.cpp

@@ -518,7 +518,7 @@ void ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline(Insert

}

// FIXME: Tolerate differences in id, class, and style attributes.

- if (isNonTableCellHTMLBlockElement(element) && areIdenticalElements(element, element->parentNode())

+ if (element->parentNode() && isNonTableCellHTMLBlockElement(element) && areIdenticalElements(element, element->parentNode())

&& VisiblePosition(firstPositionInNode(element->parentNode())) == VisiblePosition(firstPositionInNode(element))

&& VisiblePosition(lastPositionInNode(element->parentNode())) == VisiblePosition(lastPositionInNode(element))) {

insertedNodes.willRemoveNodePreservingChildren(*element);

« no previous file with comments | « LayoutTests/editing/execCommand/insert-html-to-document-element-crash-expected.txt ('k') | no next file » | no next file with comments »