Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 300143012: Check nullable value before using it in ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSp (Closed)

Created:
6 years, 6 months ago by yosin_UTC9
Modified:
6 years, 6 months ago
Reviewers:
yoichio, Yuta Kitamura
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Check nullable value before using it in ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline This patch changes removeRedundantStylesAndKeepStyleSpanInline() to check nullable value |element->parentNode()| before using it. L529, if-statement just after this change, checks |element->parentNode()| too. BUG=369422 TEST=LayoutTests/editing/execCommand/insert-html-to-document-element-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
A LayoutTests/editing/execCommand/insert-html-to-document-element-crash.html View 1 chunk +25 lines, -0 lines 0 comments Download
A + LayoutTests/editing/execCommand/insert-html-to-document-element-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance. The bug is caused by inserting PRE ...
6 years, 6 months ago (2014-05-28 06:54:55 UTC) #1
Yuta Kitamura
lgtm
6 years, 6 months ago (2014-05-28 08:48:52 UTC) #2
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 6 months ago (2014-05-29 01:33:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/300143012/1
6 years, 6 months ago (2014-05-29 01:34:14 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 01:46:25 UTC) #5
Message was sent while issue was closed.
Change committed as 175019

Powered by Google App Engine
This is Rietveld 408576698