Issue 300143005: Revert 272884 "reland 260073013: Added automatic mode to FakeInp..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 300143005: Revert 272884 "reland 260073013: Added automatic mode to FakeInp..." (Closed)

Created:
6 years, 7 months ago by Henrik Grunell

Modified:
6 years, 7 months ago

Reviewers:
no longer working on chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 272884 "reland 260073013: Added automatic mode to FakeInp..." Breaks device enumeration. BUG=377650 > reland 260073013: Added automatic mode to FakeInputAudioStream to generate automatic beeps > > Added automatic mode to FakeInputAudioStream to generate automatic beeps. > > This patch is to allow writing audio only tests using the fake input stream, also it changes the name of the fake device from "Default" to "Fake Audio, which I hope it will make things less confusing. > > Previously it broke the mac bots due to it somehow triggered crbug/288562, crbug/371271, which should have been fixed by https://codereview.chromium.org/274073002/ > > TBR=ananta@chromium.org, dalecurtis@chromium.org > > NOTRY=true > > BUG=358541 > TEST=bots existing webrtc tests. > > Review URL: https://codereview.chromium.org/279223002 TBR=xians@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272932

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -69 lines)			Patch
M	trunk/src/content/browser/renderer_host/media/audio_input_device_manager.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/audio_input_device_manager.cc	View	5 chunks	+28 lines, -24 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/audio_input_device_manager_unittest.cc	View	8 chunks	+20 lines, -1 line	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	trunk/src/media/audio/fake_audio_input_stream.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/media/audio/fake_audio_input_stream.cc	View	5 chunks	+14 lines, -33 lines	0 comments	Download
M	trunk/src/media/audio/mock_audio_manager.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r272932.

Expand Messages | Collapse Messages