Migrated test block 220 to Dart 2.0.

Migrated test block 220 to Dart 2.0.

No changes to tests.

BUG=
R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/143ea83cf3389dde52bc327db7e127b157ee7661

[bkonyi, 2017-08-22 13:07:28]

bkonyi@google.com changed reviewers:
+ rnystrom@google.com

[rmacnak, 2017-08-22 17:05:14]

rmacnak@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2017-08-22 17:05:15]

not lgtm

https://codereview.chromium.org/3001373002/diff/1/tests/lib_2/lib_2_dart2js.s...
File tests/lib_2/lib_2_dart2js.status (right):

https://codereview.chromium.org/3001373002/diff/1/tests/lib_2/lib_2_dart2js.s...
tests/lib_2/lib_2_dart2js.status:16: mirrors/*: Skip # Mirrors not supported on
d8.
These tests should not be categorically skipped on d8 or jsshell. Nothing about
them prevents dart2js from implementing mirrors, and dart2js previously has run
these tests there.

[Bob Nystrom, 2017-08-23 22:24:31]

lgtm

https://codereview.chromium.org/3001373002/diff/1/tests/lib_2/lib_2_dart2js.s...
File tests/lib_2/lib_2_dart2js.status (right):

https://codereview.chromium.org/3001373002/diff/1/tests/lib_2/lib_2_dart2js.s...
tests/lib_2/lib_2_dart2js.status:16: mirrors/*: Skip # Mirrors not supported on
d8.
On 2017/08/22 17:05:14, rmacnak wrote:
> These tests should not be categorically skipped on d8 or jsshell. Nothing
about
> them prevents dart2js from implementing mirrors, and dart2js previously has
run
> these tests there.

My understanding is the leads have decided mirrors will not be supported on
dart4web in 2.0, so we should mark everything in mirrors/* as SkipByDesign on
dart2js and dartdevc.

[rmacnak, 2017-08-23 23:33:03]

https://codereview.chromium.org/3001373002/diff/1/tests/lib_2/lib_2_dart2js.s...
File tests/lib_2/lib_2_dart2js.status (right):

https://codereview.chromium.org/3001373002/diff/1/tests/lib_2/lib_2_dart2js.s...
tests/lib_2/lib_2_dart2js.status:16: mirrors/*: Skip # Mirrors not supported on
d8.
On 2017/08/23 22:24:31, Bob Nystrom wrote:
> On 2017/08/22 17:05:14, rmacnak wrote:
> > These tests should not be categorically skipped on d8 or jsshell. Nothing
> about
> > them prevents dart2js from implementing mirrors, and dart2js previously has
> run
> > these tests there.
> 
> My understanding is the leads have decided mirrors will not be supported on
> dart4web in 2.0, so we should mark everything in mirrors/* as SkipByDesign on
> dart2js and dartdevc.

As long as we are shipping a Dart 1 SDK, we must maintain test coverage.

[Bob Nystrom, 2017-08-24 16:17:13]

On 2017/08/23 23:33:03, rmacnak wrote:
>
https://codereview.chromium.org/3001373002/diff/1/tests/lib_2/lib_2_dart2js.s...
> File tests/lib_2/lib_2_dart2js.status (right):
> 
>
https://codereview.chromium.org/3001373002/diff/1/tests/lib_2/lib_2_dart2js.s...
> tests/lib_2/lib_2_dart2js.status:16: mirrors/*: Skip # Mirrors not supported
on
> d8.
> On 2017/08/23 22:24:31, Bob Nystrom wrote:
> > On 2017/08/22 17:05:14, rmacnak wrote:
> > > These tests should not be categorically skipped on d8 or jsshell. Nothing
> > about
> > > them prevents dart2js from implementing mirrors, and dart2js previously
has
> > run
> > > these tests there.
> > 
> > My understanding is the leads have decided mirrors will not be supported on
> > dart4web in 2.0, so we should mark everything in mirrors/* as SkipByDesign
on
> > dart2js and dartdevc.
> 
> As long as we are shipping a Dart 1 SDK, we must maintain test coverage.

We aren't any more. The reason these tests are being migrated to 2.0 is because
we *have* crossed the threshold where we are no longer shipping Dart 1.0 SDKs
based on the master branch of the repo.

– bob

[bkonyi, 2017-08-31 14:17:04]

Description was changed from

==========
Migrated test block 220 to Dart 2.0.

No changes to tests.

BUG=
==========

to

==========
Migrated test block 220 to Dart 2.0.

No changes to tests.

BUG=
R=rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/143ea83cf3389dde52bc327db7e127b157ee7661
==========

[bkonyi, 2017-08-31 14:17:06]

Committed patchset #1 (id:1) manually as
143ea83cf3389dde52bc327db7e127b157ee7661.