Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: tests/lib_2/lib_2_dart2js.status

Issue 3001373002: Migrated test block 220 to Dart 2.0. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/generic_type_mirror_test.dart ('k') | tests/lib_2/lib_2_dartdevc.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib_2/lib_2_dart2js.status
diff --git a/tests/lib_2/lib_2_dart2js.status b/tests/lib_2/lib_2_dart2js.status
index e05cbe35cc84f813799579db03a9f7eeede1d836..3a2ba91319f914c52deb065899ae30650316f700 100644
--- a/tests/lib_2/lib_2_dart2js.status
+++ b/tests/lib_2/lib_2_dart2js.status
@@ -10,9 +10,16 @@ async/catch_errors20_test: Fail # Timer interface not supported: Issue 7728.
async/catch_errors28_test: Fail # Timer interface not supported: Issue 7728.
async/future_test: RuntimeError # Timer interface not supported; Issue 7728.
async/future_constructor2_test: Fail # Timer interface not supported: Issue 7728.
+mirrors/*: Skip # Mirrors not supported on jsshell.
+
+[ $compiler == dart2js && $runtime == d8 ]
+mirrors/*: Skip # Mirrors not supported on d8.
rmacnak 2017/08/22 17:05:14 These tests should not be categorically skipped on
Bob Nystrom 2017/08/23 22:24:31 My understanding is the leads have decided mirrors
rmacnak 2017/08/23 23:33:03 As long as we are shipping a Dart 1 SDK, we must m
[ $compiler == dart2js ]
async/future_or_strong_test: RuntimeError
+mirrors/generic_local_function_test: RuntimeError # Issue 12333
+mirrors/generic_mixin_test: RuntimeError # Issue 12333
+mirrors/generic_mixin_applications_test: RuntimeError # Issue 12333
[ $compiler != dart2js ]
async/dart2js_uncaught_error_test: Skip # JS-integration only test
« no previous file with comments | « tests/lib/mirrors/generic_type_mirror_test.dart ('k') | tests/lib_2/lib_2_dartdevc.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698