Split generated_bindings.gyp into core and modules (1/2)

Split generated_bindings.gyp into core and modules (1/2)

This splits the files, except for generating individual bindings
(that's long, so I'll do it separately).

This is a bit big b/c it's refactoring, but it's just splitting things up, and isolating core and modules from complexity in bindings.

Also adds FIXMEs with links to bugs for followups.

Immediate followups:
1. Split off individual binding generation (completes split at GYP level)
2. Split off/cleanup script GYP (currently a bit intricate, will simplify).

R=haraken
TBR=Nico
BUG=358074
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174833

[Nils Barth (inactive), 2014-05-26 05:51:11]

Main GYP split (omits individual bindings b/c that's long, will do in followup).

https://codereview.chromium.org/300133002/diff/20001/Source/bindings/core/cor...
File Source/bindings/core/core.gypi (right):

https://codereview.chromium.org/300133002/diff/20001/Source/bindings/core/cor...
Source/bindings/core/core.gypi:1: # Copyright 2014 The Chromium Authors. All
rights reserved.
This file (and module/modules.gypi) mean core.gyp and modules.gyp don't need to
care about internal structure of bindings GYP!

https://codereview.chromium.org/300133002/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/generated.gypi (right):

https://codereview.chromium.org/300133002/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/generated.gypi:12:
'<(bindings_output_dir)/V8GeneratedCoreBindings.cpp',
We'll need to keep this on Windows, but hopefully can eliminate the aggregate
files on non-Windows, which will make this simpler.

https://codereview.chromium.org/300133002/diff/20001/Source/bindings/generate...
File Source/bindings/generated.gyp (right):

https://codereview.chromium.org/300133002/diff/20001/Source/bindings/generate...
Source/bindings/generated.gyp:38: 'idl.gypi',
! All we care about is the list of IDL files !

https://codereview.chromium.org/300133002/diff/20001/Source/core/core.gyp
File Source/core/core.gyp (right):

https://codereview.chromium.org/300133002/diff/20001/Source/core/core.gyp#new...
Source/core/core.gyp:36: '../bindings/core/core.gypi',
Now depends only on bindings_core (GYP-wise)!
Still dependencies on modules in C++ though.

[haraken, 2014-05-26 07:10:52]

LGTM, but I'd like to have Nico take another look.

https://codereview.chromium.org/300133002/diff/20001/Source/bindings/core/cor...
File Source/bindings/core/core.gypi (right):

https://codereview.chromium.org/300133002/diff/20001/Source/bindings/core/cor...
Source/bindings/core/core.gypi:1: # Copyright 2014 The Chromium Authors. All
rights reserved.
On 2014/05/26 05:51:11, Nils Barth wrote:
> This file (and module/modules.gypi) mean core.gyp and modules.gyp don't need
to
> care about internal structure of bindings GYP!

Cool. Would you write a comment about it in core.gypi and modules.gypi, so that
others won't add something unexpected in the future?

[Nils Barth (inactive), 2014-05-26 07:43:45]

https://codereview.chromium.org/300133002/diff/20001/Source/bindings/core/cor...
File Source/bindings/core/core.gypi (right):

https://codereview.chromium.org/300133002/diff/20001/Source/bindings/core/cor...
Source/bindings/core/core.gypi:1: # Copyright 2014 The Chromium Authors. All
rights reserved.
On 2014/05/26 07:10:52, haraken wrote:
> On 2014/05/26 05:51:11, Nils Barth wrote:
> > This file (and module/modules.gypi) mean core.gyp and modules.gyp don't need
> to
> > care about internal structure of bindings GYP!
> 
> Cool. Would you write a comment about it in core.gypi and modules.gypi, so
that
> others won't add something unexpected in the future?

Done!

[Nils Barth (inactive), 2014-05-26 07:44:34]

Thanks for review haraken!

Hi Nico,
We're splitting the .gyp & .gypi in bindings for componentization; could you
take a look at this?
Thanks!

[Nils Barth (inactive), 2014-05-27 02:19:58]

As Nico is OoO traveling, and GYP will hopefully be replaced by GN soon, TBRing
Nico.
(We'll work to make GYP clean, but as it'll be restructured once in the GN-only
world,
not worth stressing about fine details.)

[Nils Barth (inactive), 2014-05-27 02:20:04]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-05-27 02:20:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nbarth@chromium.org/300133002/80001

[commit-bot: I haz the power, 2014-05-27 03:40:45]

Change committed as 174833

[Nico, 2014-05-27 07:52:20]

On Tue, May 27, 2014 at 4:19 AM, <nbarth@chromium.org> wrote:

> As Nico is OoO traveling, and GYP will hopefully be replaced by GN soon,
> TBRing
> Nico.
>

It's fine to tbr me, but "gyp is hopefully no longer with us soon"
shouldn't be used to justify anything at this point. Currently, the switch
is scheduled to happen end of this year at the earliest.


> (We'll work to make GYP clean, but as it'll be restructured once in the
> GN-only
> world,
> not worth stressing about fine details.)
>
> https://codereview.chromium.org/300133002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Nils Barth (inactive), 2014-05-27 07:53:32]

On 2014/05/27 07:52:20, Nico (traveling) wrote:
> On Tue, May 27, 2014 at 4:19 AM, <mailto:nbarth@chromium.org> wrote:
> 
> > As Nico is OoO traveling, and GYP will hopefully be replaced by GN soon,
> > TBRing
> > Nico.
> >
> 
> It's fine to tbr me, but "gyp is hopefully no longer with us soon"
> shouldn't be used to justify anything at this point. Currently, the switch
> is scheduled to happen end of this year at the earliest.

OIC; sorry for jumping the gun, and thanks for update!