Source/bindings/core/core.gypi - Issue 300133002: Split generated_bindings.gyp into core and modules (1/2)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/core/core.gypi

Issue 300133002: Split generated_bindings.gyp into core and modules (1/2) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Cleaner Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.
	Nils Barth (inactive) 2014/05/26 05:51:11 This file (and module/modules.gypi) mean core.gyp This file (and module/modules.gypi) mean core.gyp and modules.gyp don't need to care about internal structure of bindings GYP! haraken 2014/05/26 07:10:52 Cool. Would you write a comment about it in core.g Show quoted text On 2014/05/26 05:51:11, Nils Barth wrote: > This file (and module/modules.gypi) mean core.gyp and modules.gyp don't need to > care about internal structure of bindings GYP! Cool. Would you write a comment about it in core.gypi and modules.gypi, so that others won't add something unexpected in the future? Nils Barth (inactive) 2014/05/26 07:43:45 Done! Show quoted text On 2014/05/26 07:10:52, haraken wrote: > On 2014/05/26 05:51:11, Nils Barth wrote: > > This file (and module/modules.gypi) mean core.gyp and modules.gyp don't need > to > > care about internal structure of bindings GYP! > > Cool. Would you write a comment about it in core.gypi and modules.gypi, so that > others won't add something unexpected in the future? Done!
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'includes': [

	7 '../bindings.gypi',

	8 'v8/generated.gypi',

	9 ],

	10 }

OLD	NEW