Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 3001193002: VideoProcessorIntegrationTest: mini-fixes in preparation for task queue CL. (Closed)

Created:
3 years, 4 months ago by brandtr
Modified:
3 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoProcessorIntegrationTest: mini-fixes in preparation for task queue CL. * Rename some members. * Shorten visualization file names. * Make some member functions static, in preparation for moving them to be helper functions in an anonymous namespace. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/3001193002 Cr-Commit-Position: refs/heads/master@{#19424} Committed: https://chromium.googlesource.com/external/webrtc/+/ed0e4366887137606fae2a57d7df1001848d21d1

Patch Set 1 #

Total comments: 4

Patch Set 2 : asapersson comments 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -46 lines) Patch
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 17 chunks +49 lines, -46 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
brandtr
3 years, 4 months ago (2017-08-18 13:42:29 UTC) #2
åsapersson
lgtm https://codereview.webrtc.org/3001193002/diff/1/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h (right): https://codereview.webrtc.org/3001193002/diff/1/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h#newcode657 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:657: int bit_rate_kbps, maybe bitrate_kbps https://codereview.webrtc.org/3001193002/diff/1/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h#newcode658 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:658: int frame_rate_fps, ...
3 years, 4 months ago (2017-08-21 07:30:07 UTC) #3
brandtr
https://codereview.webrtc.org/3001193002/diff/1/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h (right): https://codereview.webrtc.org/3001193002/diff/1/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h#newcode657 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:657: int bit_rate_kbps, On 2017/08/21 07:30:07, åsapersson wrote: > maybe ...
3 years, 4 months ago (2017-08-21 07:57:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3001193002/20001
3 years, 4 months ago (2017-08-21 11:13:02 UTC) #11
commit-bot: I haz the power
3 years, 4 months ago (2017-08-21 11:15:33 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/ed0e4366887137606fae2a57d...

Powered by Google App Engine
This is Rietveld 408576698