dashboard/dashboard/pinpoint/models/attempt.py - Issue 3001163002: Pinpoint - Surface info from executions for display in UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dashboard/dashboard/pinpoint/models/attempt.py

Issue 3001163002: Pinpoint - Surface info from executions for display in UI. (Closed)

Patch Set: Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dashboard/dashboard/pinpoint/models/attempt.py

diff --git a/dashboard/dashboard/pinpoint/models/attempt.py b/dashboard/dashboard/pinpoint/models/attempt.py

index f40f5d9713a65614a6233afd6089cc0edd4d72c7..6bae3295caaa3e3fdfa5eda9e57126847e1741f1 100644

--- a/dashboard/dashboard/pinpoint/models/attempt.py

+++ b/dashboard/dashboard/pinpoint/models/attempt.py

@@ -48,6 +48,10 @@ class Attempt(object):

return dict((quest, execution.result_values)

for quest, execution in zip(self._quests, self._executions))

+ def AsDictPerQuest(self):

dtu 2017/08/21 23:52:52 nit: put methods after properties

dtu 2017/08/21 23:52:52 It would be more consistent to provide an Attempt.

shatch 2017/08/22 01:23:55 Done.

+ return dict((quest, execution.AsDict())

+ for quest, execution in zip(self._quests, self._executions))

@property

def _last_execution(self):

return self._executions[-1]