Pinpoint - Surface info from executions for display in UI.

dashboard/dashboard/pinpoint/models/attempt.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 class Attempt(object):
   """One run of all the Quests on a Change.
 
   Each Change should execute at least one Attempt. The user can request more
   runs, which creates additional Attempts. The bisect algorithm may also create
@@ skipping 30 matching lines @@
     return self._last_execution.failed or (
         self._last_execution.completed and
         len(self._quests) == len(self._executions))
 
   @property
   def result_values(self):
     assert self.completed
     return dict((quest, execution.result_values)
                 for quest, execution in zip(self._quests, self._executions))
 
+  def AsDictPerQuest(self):

[dtu, 2017/08/21 23:52:52]

nit: put methods after properties

[dtu, 2017/08/21 23:52:52]

It would be more consistent to provide an Attempt.AsDict() that gives
'executions' as a flat list.

[shatch, 2017/08/22 01:23:55]

Done.

[shatch, 2017/08/22 01:23:55]

Done.

+    return dict((quest, execution.AsDict())
+                for quest, execution in zip(self._quests, self._executions))
+
   @property
   def _last_execution(self):
     return self._executions[-1]
 
   def ScheduleWork(self):
     """Run this Attempt and update its status."""
     assert not self.completed
 
     self._StartNextExecutionIfReady()
     self._Poll()
 
   def _Poll(self):
     """Update the Attempt status."""
     self._last_execution.Poll()
 
   def _StartNextExecutionIfReady(self):
     can_start_next_execution = not self._executions or (
         self._last_execution.completed and not self.completed)
     if not can_start_next_execution:
       return
 
     next_quest = self._quests[len(self._executions)]
     if self._executions:
       arguments = self._last_execution.result_arguments
     else:
       arguments = {'change': self._change}
 
     self._executions.append(next_quest.Start(**arguments))