Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 300113008: Make image scaling have floating point scales. Third attempt to land this (Closed)

Created:
6 years, 7 months ago by humper
Modified:
6 years, 6 months ago
Reviewers:
epoger, bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Make image scaling have floating point scales. Third attempt to land this due to some struggles with the CQ. Original CL here: https://codereview.chromium.org/298243003/ BUG= TBR=epoger, bsalomon Committed: http://code.google.com/p/skia/source/detail?r=14920

Patch Set 1 #

Patch Set 2 : add gm source #

Patch Set 3 : disable some GMs #

Patch Set 4 : rebase #

Patch Set 5 : Windows build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -53 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A gm/filterindiabox.cpp View 1 2 3 4 1 chunk +139 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 3 chunks +9 lines, -2 lines 0 comments Download
M src/core/SkBitmapScaler.h View 1 chunk +1 line, -19 lines 0 comments Download
M src/core/SkBitmapScaler.cpp View 9 chunks +19 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
humper
The CQ bit was checked by humper@google.com
6 years, 6 months ago (2014-05-28 16:26:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/300113008/40001
6 years, 6 months ago (2014-05-28 16:26:50 UTC) #2
humper
The CQ bit was unchecked by humper@google.com
6 years, 6 months ago (2014-05-28 16:47:16 UTC) #3
humper
The CQ bit was checked by humper@google.com
6 years, 6 months ago (2014-05-28 17:21:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/300113008/80001
6 years, 6 months ago (2014-05-28 17:21:50 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 17:30:05 UTC) #6
Message was sent while issue was closed.
Change committed as 14920

Powered by Google App Engine
This is Rietveld 408576698