floating point scale factors for images

floating point scale factors for images

not running trybots because binary files.

BUG=
NOTRY=True

[humper, 2014-05-27 17:14:02]

ptal

[reed1, 2014-05-27 18:03:36]

lgtm -- waiting on Brian

Following suggestions:

1. cleanly remove the remnants of dstrect (which we haven't tested)
2. after #1, lets investigate supporting subpixel positioning (maybe an animated
test will show this) since the current code always snaps the "dst" to 0,0 in
top/left

[bsalomon, 2014-05-27 18:47:03]

lgtm

Do we need to support fractional subpixel src rects in addition to subpixel dst
positioning?

On 2014/05/27 18:03:36, reed1 wrote:
> lgtm -- waiting on Brian
> 
> Following suggestions:
> 
> 1. cleanly remove the remnants of dstrect (which we haven't tested)


> 2. after #1, lets investigate supporting subpixel positioning (maybe an
animated
> test will show this) since the current code always snaps the "dst" to 0,0 in
> top/left

[reed1, 2014-05-27 19:02:46]

On 2014/05/27 18:47:03, bsalomon wrote:
> lgtm
> 
> Do we need to support fractional subpixel src rects in addition to subpixel
dst
> positioning?

Yes. Though I'm ok making that a 2nd CL.

> 
> On 2014/05/27 18:03:36, reed1 wrote:
> > lgtm -- waiting on Brian
> > 
> > Following suggestions:
> > 
> > 1. cleanly remove the remnants of dstrect (which we haven't tested)
> 
> 
> > 2. after #1, lets investigate supporting subpixel positioning (maybe an
> animated
> > test will show this) since the current code always snaps the "dst" to 0,0 in
> > top/left

[reed1, 2014-05-27 19:03:02]

On 2014/05/27 19:02:46, reed1 wrote:
> On 2014/05/27 18:47:03, bsalomon wrote:
> > lgtm
> > 
> > Do we need to support fractional subpixel src rects in addition to subpixel
> dst
> > positioning?
> 
> Yes. Though I'm ok making that a 2nd CL.

Or a 3rd, if we first do more cleanup of dstrect

> 
> > 
> > On 2014/05/27 18:03:36, reed1 wrote:
> > > lgtm -- waiting on Brian
> > > 
> > > Following suggestions:
> > > 
> > > 1. cleanly remove the remnants of dstrect (which we haven't tested)
> > 
> > 
> > > 2. after #1, lets investigate supporting subpixel positioning (maybe an
> > animated
> > > test will show this) since the current code always snaps the "dst" to 0,0
in
> > > top/left

[humper, 2014-05-27 20:08:26]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-05-27 20:08:41]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/humper@google.com/298243003/40001

[commit-bot: I haz the power, 2014-05-27 20:08:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 20:08:45]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: Can't process patch for file resources/box.gif.
Binary file is empty. Maybe the file wasn't uploaded in the first place?

[epoger, 2014-05-27 20:33:38]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-05-27 20:33:57]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/humper@google.com/298243003/40001

[commit-bot: I haz the power, 2014-05-27 20:34:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 20:34:01]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: Can't process patch for file resources/box.gif.
Binary file is empty. Maybe the file wasn't uploaded in the first place?

[humper, 2014-05-27 20:35:02]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-05-27 20:35:27]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/humper@google.com/298243003/40001

[commit-bot: I haz the power, 2014-05-27 20:35:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 20:35:32]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: Can't process patch for file resources/box.gif.
Binary file is empty. Maybe the file wasn't uploaded in the first place?

[humper, 2014-05-27 20:37:01]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-05-27 20:37:18]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/humper@google.com/298243003/40001

[commit-bot: I haz the power, 2014-05-27 20:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 20:37:23]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: Can't process patch for file resources/box.gif.
Binary file is empty. Maybe the file wasn't uploaded in the first place?

[humper, 2014-05-27 20:41:41]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-05-27 20:42:03]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/humper@google.com/298243003/40001

[commit-bot: I haz the power, 2014-05-27 20:42:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 20:42:08]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: Can't process patch for file resources/box.gif.
Binary file is empty. Maybe the file wasn't uploaded in the first place?

[reed1, 2014-08-05 19:01:45]

can we cons-up a test image, rather than needing this GIF? or are its contents
hard to reproduce programmatically?

Just to re-iterate my first comment: I think we should really be taking a
float-rect instead of just width/height, otherwise we are artificially forcing
top/left phase alignment.