Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1904)

Unified Diff: dashboard/dashboard/pinpoint/models/quest/find_isolate.py

Issue 3001043002: [pinpoint] Add ReadGraphJsonValue. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/pinpoint/models/quest/find_isolate.py
diff --git a/dashboard/dashboard/pinpoint/models/quest/find_isolate.py b/dashboard/dashboard/pinpoint/models/quest/find_isolate.py
index 71ea3041dbcd5ffb807659b799f0dc30c3bda18b..11a2a20dc3558b0a7a89a0ac186a5135ed3db2fb 100644
--- a/dashboard/dashboard/pinpoint/models/quest/find_isolate.py
+++ b/dashboard/dashboard/pinpoint/models/quest/find_isolate.py
@@ -17,8 +17,9 @@ class BuildError(Exception):
class FindIsolate(quest.Quest):
- def __init__(self, configuration):
+ def __init__(self, configuration, target):
self._builder_name = _BuilderNameForConfiguration(configuration)
+ self._target = target
def __eq__(self, other):
return (isinstance(other, type(self)) and
@@ -32,23 +33,22 @@ class FindIsolate(quest.Quest):
return 1
def Start(self, change):
- return _FindIsolateExecution(self._builder_name, change)
+ return _FindIsolateExecution(self._builder_name, self._target, change)
class _FindIsolateExecution(execution.Execution):
- def __init__(self, builder_name, change):
+ def __init__(self, builder_name, target, change):
super(_FindIsolateExecution, self).__init__()
self._builder_name = builder_name
+ self._target = target
self._change = change
self._build = None
def _Poll(self):
# Look for the .isolate in our cache.
- # TODO: Support other isolate targets.
- target = 'telemetry_perf_tests'
try:
- isolate_hash = isolate.Get(self._builder_name, self._change, target)
+ isolate_hash = isolate.Get(self._builder_name, self._change, self._target)
except KeyError:
isolate_hash = None
« no previous file with comments | « no previous file | dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698