Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 3001003002: update AstBuilder to support part of <uri> (Closed)

Created:
3 years, 4 months ago by danrubel
Modified:
3 years, 4 months ago
Reviewers:
Paul Berry, kevmoo
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -25 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 chunk +8 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 2 chunks +2 lines, -21 lines 2 comments Download
M pkg/front_end/testcases/strong.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
danrubel
3 years, 4 months ago (2017-08-16 19:04:02 UTC) #2
Paul Berry
lgtm
3 years, 4 months ago (2017-08-16 19:31:01 UTC) #3
kevmoo
https://codereview.chromium.org/3001003002/diff/1/pkg/analyzer/test/generated/parser_fasta_test.dart File pkg/analyzer/test/generated/parser_fasta_test.dart (right): https://codereview.chromium.org/3001003002/diff/1/pkg/analyzer/test/generated/parser_fasta_test.dart#newcode286 pkg/analyzer/test/generated/parser_fasta_test.dart:286: throw new UnimplementedError(); Nit: might be nice to actually ...
3 years, 4 months ago (2017-08-16 20:36:29 UTC) #5
danrubel
https://codereview.chromium.org/3001003002/diff/1/pkg/analyzer/test/generated/parser_fasta_test.dart File pkg/analyzer/test/generated/parser_fasta_test.dart (right): https://codereview.chromium.org/3001003002/diff/1/pkg/analyzer/test/generated/parser_fasta_test.dart#newcode286 pkg/analyzer/test/generated/parser_fasta_test.dart:286: throw new UnimplementedError(); On 2017/08/16 20:36:29, kevmoo wrote: > ...
3 years, 4 months ago (2017-08-17 12:51:56 UTC) #6
danrubel
3 years, 4 months ago (2017-08-17 12:52:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd10e9ff06dfb8fd5a48a770bc96544526b67570 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698