Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2180)

Unified Diff: pkg/analyzer/test/generated/parser_fasta_test.dart

Issue 3001003002: update AstBuilder to support part of <uri> (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/fasta/ast_builder.dart ('k') | pkg/front_end/testcases/strong.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/parser_fasta_test.dart
diff --git a/pkg/analyzer/test/generated/parser_fasta_test.dart b/pkg/analyzer/test/generated/parser_fasta_test.dart
index 30d92ae2eb3b3b17b44c94a5e17a552bd3412ba8..ba8624bd3d83dce2f13b90f2519865c90775eefb 100644
--- a/pkg/analyzer/test/generated/parser_fasta_test.dart
+++ b/pkg/analyzer/test/generated/parser_fasta_test.dart
@@ -281,9 +281,8 @@ class FastaParserTestCase extends Object
@override
set enableUriInPartOf(bool value) {
- if (value == true) {
- // TODO(paulberry,ahe): URIs in "part of" declarations are not supported
- // by Fasta.
+ if (value == false) {
+ // URIs in "part of" declarations cannot be disabled in Fasta.
throw new UnimplementedError();
kevmoo 2017/08/16 20:36:29 Nit: might be nice to actually put the content of
danrubel 2017/08/17 12:51:55 Good point. Done.
}
}
@@ -999,24 +998,6 @@ class TopLevelParserTest_Fasta extends FastaParserTestCase
super.test_parseDirectives_mixed();
}
- @override
- @failingTest
- void test_parsePartOfDirective_name() {
- // TODO(paulberry,ahe): Thes test verifies that even if URIs in "part of"
- // declarations are enabled, a construct of the form "part of identifier;"
- // is still properly handled. URIs in "part of" declarations are not
- // supported by Fasta yet.
- super.test_parsePartOfDirective_name();
- }
-
- @override
- @failingTest
- void test_parsePartOfDirective_uri() {
- // TODO(paulberry,ahe): URIs in "part of" declarations are not supported by
- // Fasta.
- super.test_parsePartOfDirective_uri();
- }
-
@failingTest
void test_parseCompilationUnit_operatorAsPrefix_parameterized2() {
// TODO(danrubel): should not be generating an error
« no previous file with comments | « pkg/analyzer/lib/src/fasta/ast_builder.dart ('k') | pkg/front_end/testcases/strong.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698