Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 3000953002: Use Bot in compare_failures (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -39 lines) Patch
M tools/gardening/bin/compare_failures.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M tools/gardening/lib/src/bot.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/gardening/lib/src/client.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tools/gardening/lib/src/compare_failures_impl.dart View 3 chunks +17 lines, -19 lines 0 comments Download
M tools/gardening/test/compare_failures_test.dart View 5 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-15 12:27:21 UTC) #2
floitsch
LGTM.
3 years, 4 months ago (2017-08-15 12:39:40 UTC) #3
Johnni Winther
3 years, 4 months ago (2017-08-15 12:52:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d2676d2f1641b5eba35f13a55ecec18a0d956185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698