Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: tools/gardening/lib/src/bot.dart

Issue 3000953002: Use Bot in compare_failures (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gardening/bin/compare_failures.dart ('k') | tools/gardening/lib/src/client.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gardening/lib/src/bot.dart
diff --git a/tools/gardening/lib/src/bot.dart b/tools/gardening/lib/src/bot.dart
index 9d0af669e1515524a553d2cc06273b177cae765e..56015c326c548fd1b315527736db82006c115b60 100644
--- a/tools/gardening/lib/src/bot.dart
+++ b/tools/gardening/lib/src/bot.dart
@@ -10,16 +10,16 @@ import 'client.dart';
import 'util.dart';
class Bot {
- final bool usesLogdog;
final BuildbotClient _client;
/// Instantiates a Bot.
///
/// Bots must be [close]d when they aren't needed anymore.
Bot({bool logdog = false})
- : usesLogdog = logdog,
- _client =
- logdog ? new LogdogBuildbotClient() : new HttpBuildbotClient();
+ : this.internal(
+ logdog ? new LogdogBuildbotClient() : new HttpBuildbotClient());
+
+ Bot.internal(this._client);
int get mostRecentBuildNumber => _client.mostRecentBuildNumber;
« no previous file with comments | « tools/gardening/bin/compare_failures.dart ('k') | tools/gardening/lib/src/client.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698