Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 300093002: Revert 272740 "Refactor and move ash independent accelerator han..." (Closed)

Created:
6 years, 7 months ago by mmenke
Modified:
6 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 272740 "Refactor and move ash independent accelerator han..." Causing compile failures on Windows. Possible comatability issue with https://codereview.chromium.org/298703007 Sample errors: FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\ui\wm\core\wm_unittests.nested_accelerator_controller_unittest.obj.rsp /c ..\..\ui\wm\core\nested_accelerator_controller_unittest.cc /Foobj\ui\wm\core\wm_unittests.nested_accelerator_controller_unittest.obj /Fdobj\ui\wm\wm_unittests.cc.pdb c:\b\build\slave\win\build\src\ui\wm\core\nested_accelerator_controller_unittest.cc(83) : error C2039: 'host' : is not a member of 'aura::Window' c:\b\build\slave\win\build\src\ui\aura\window.h(62) : see declaration of 'aura::Window' c:\b\build\slave\win\build\src\ui\wm\core\nested_accelerator_controller_unittest.cc(83) : error C2227: left of '->PostNativeEvent' must point to class/struct/union/generic type c:\b\build\slave\win\build\src\ui\wm\core\nested_accelerator_controller_unittest.cc(85) : error C2039: 'host' : is not a member of 'aura::Window' c:\b\build\slave\win\build\src\ui\aura\window.h(62) : see declaration of 'aura::Window' c:\b\build\slave\win\build\src\ui\wm\core\nested_accelerator_controller_unittest.cc(85) : error C2227: left of '->PostNativeEvent' must point to class/struct/union/generic type ninja: build stopped: subcommand failed. > Refactor and move ash independent accelerator handling code in nested loop to ui/wm/core > > I also renamed classes to NestedAcceleratorXxx. I felt this is a bit more clearer than NestedDispatcher, especially in ui/wm/core. Please let me know if you disagree or have better suggestion. I'm happy to rename them. > > BUG=None > > Review URL: https://codereview.chromium.org/298703007 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -684 lines) Patch
A + trunk/src/ash/accelerators/accelerator_dispatcher.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/accelerators/accelerator_dispatcher.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/accelerators/accelerator_dispatcher_linux.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/accelerators/accelerator_dispatcher_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/ash/accelerators/nested_accelerator_delegate.h View 1 chunk +0 lines, -28 lines 0 comments Download
D trunk/src/ash/accelerators/nested_accelerator_delegate.cc View 1 chunk +0 lines, -77 lines 0 comments Download
A + trunk/src/ash/accelerators/nested_dispatcher_controller.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/accelerators/nested_dispatcher_controller.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/accelerators/nested_dispatcher_controller_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ash/ash.gyp View 4 chunks +8 lines, -3 lines 0 comments Download
M trunk/src/ash/shell.h View 3 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/shell.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M trunk/src/ui/wm/core/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/ui/wm/core/nested_accelerator_controller.h View 1 chunk +0 lines, -43 lines 0 comments Download
D trunk/src/ui/wm/core/nested_accelerator_controller.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D trunk/src/ui/wm/core/nested_accelerator_controller_unittest.cc View 1 chunk +0 lines, -201 lines 0 comments Download
D trunk/src/ui/wm/core/nested_accelerator_delegate.h View 1 chunk +0 lines, -31 lines 0 comments Download
D trunk/src/ui/wm/core/nested_accelerator_dispatcher.h View 1 chunk +0 lines, -55 lines 0 comments Download
D trunk/src/ui/wm/core/nested_accelerator_dispatcher.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D trunk/src/ui/wm/core/nested_accelerator_dispatcher_linux.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D trunk/src/ui/wm/core/nested_accelerator_dispatcher_win.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M trunk/src/ui/wm/wm.gyp View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mmenke
6 years, 7 months ago (2014-05-25 13:35:03 UTC) #1
mmenke
6 years, 7 months ago (2014-05-25 13:35:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r272759 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698